mirror of
https://github.com/dart-lang/sdk
synced 2024-09-18 21:41:19 +00:00
e85042b403
Error tests with explicit line/column markers, like [error line 123, column 456] currently require both "line" and "column". All existing occurrences of `[error line 123, column 456]` always refer to the most recent non-comment line *just like* the `// ^^` lines, so omitting the line, and having the most recent non-comment line as the *default* line, seems reasonable. This CL makes the line optional, the new format without a "line" entry will be just `[error column 456]`. This allows files to change the number of lines in the code without invalidating any later expectations. (Or, say, remove a comment line at the top of the file!) Omits the line entry by default when writing/updating expectations. Change-Id: Ia0c95bf804a1c6b11c0c1621bfd481e43f8fa0c0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200429 Commit-Queue: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com> |
||
|---|---|---|
| .. | ||
| dependency_graph_test.dart | ||
| experiment_test.dart | ||
| options_test.dart | ||
| skipping_dart2js_compilations_helper.dart | ||
| skipping_dart2js_compilations_test.dart | ||
| static_error_test.dart | ||
| test_file_test.dart | ||
| test_runner_test.dart | ||
| test_suite_test.dart | ||
| update_errors_test.dart | ||
| utils.dart | ||