mirror of
https://github.com/dart-lang/sdk
synced 2024-10-06 12:35:03 +00:00
eaebf15f43
The stack frame iteration during GC was missing one slot in stub frames that did not save the pool pointer. - This change makes all stub frames uniform, i.e they always save/restore the pool pointer. This ensures that we will traverse all slots on the stack. - A new constant called kFirstObjectSlotFromFp has been added which is used as the slot to start stack traversal. (The ARM and MIPs changes will be in a different CL) R=iposva@google.com, regis@google.com, zra@google.com Review URL: https://codereview.chromium.org//63093003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30088 260f80e4-7a28-3924-810f-c04153c831b5
56 lines
1.6 KiB
C++
56 lines
1.6 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "platform/assert.h"
|
|
#include "vm/globals.h"
|
|
#if defined(TARGET_ARCH_X64)
|
|
|
|
#include "vm/assembler.h"
|
|
#include "vm/object.h"
|
|
#include "vm/unit_test.h"
|
|
|
|
namespace dart {
|
|
|
|
#define __ assembler->
|
|
|
|
|
|
// Generate a simple dart code sequence.
|
|
// This is used to test Code and Instruction object creation.
|
|
void GenerateIncrement(Assembler* assembler) {
|
|
__ movq(RAX, Immediate(0));
|
|
__ pushq(RAX);
|
|
__ incq(Address(RSP, 0));
|
|
__ movq(RCX, Address(RSP, 0));
|
|
__ incq(RCX);
|
|
__ popq(RAX);
|
|
__ movq(RAX, RCX);
|
|
__ ret();
|
|
}
|
|
|
|
|
|
// Generate a dart code sequence that embeds a string object in it.
|
|
// This is used to test Embedded String objects in the instructions.
|
|
void GenerateEmbedStringInCode(Assembler* assembler, const char* str) {
|
|
const String& string_object =
|
|
String::ZoneHandle(String::New(str, Heap::kOld));
|
|
__ pushq(PP); // Save caller's pool pointer and load a new one here.
|
|
__ LoadPoolPointer(PP);
|
|
__ LoadObject(RAX, string_object, PP);
|
|
__ popq(PP); // Restore caller's pool pointer.
|
|
__ ret();
|
|
}
|
|
|
|
|
|
// Generate a dart code sequence that embeds a smi object in it.
|
|
// This is used to test Embedded Smi objects in the instructions.
|
|
void GenerateEmbedSmiInCode(Assembler* assembler, intptr_t value) {
|
|
const Smi& smi_object = Smi::ZoneHandle(Smi::New(value));
|
|
__ movq(RAX, Immediate(reinterpret_cast<int64_t>(smi_object.raw())));
|
|
__ ret();
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_X64
|