mirror of
https://github.com/dart-lang/sdk
synced 2024-10-06 12:22:09 +00:00
d6178535b2
Change executable pages to be read/execute but not writable by default. All pages are made temporarily writable just before a full GC, because both the mark and sweep phases write to the pages. When allocating in a page and when patching code, the pages are made temporarily writable. The order of allocation of Code and Instructions objects is changed so that a GC will not occur after Instructions is allocated. (A full GC would render the Instructions unwritable.) A scoped object is used to make memory protection simpler. Original CL: https://codereview.chromium.org/106593002/ I added a cc test that is expected to crash. R=srdjan@google.com Review URL: https://codereview.chromium.org//136563002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32493 260f80e4-7a28-3924-810f-c04153c831b5
91 lines
2.7 KiB
C++
91 lines
2.7 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h"
|
|
#if defined(TARGET_ARCH_MIPS)
|
|
|
|
#include "vm/code_patcher.h"
|
|
#include "vm/cpu.h"
|
|
#include "vm/debugger.h"
|
|
#include "vm/instructions.h"
|
|
#include "vm/stub_code.h"
|
|
|
|
namespace dart {
|
|
|
|
RawInstance* ActivationFrame::GetInstanceCallReceiver(
|
|
intptr_t num_actual_args) {
|
|
ASSERT(num_actual_args > 0); // At minimum we have a receiver on the stack.
|
|
// Stack pointer points to last argument that was pushed on the stack.
|
|
uword receiver_addr = sp() + ((num_actual_args - 1) * kWordSize);
|
|
return reinterpret_cast<RawInstance*>(
|
|
*reinterpret_cast<uword*>(receiver_addr));
|
|
}
|
|
|
|
|
|
RawObject* ActivationFrame::GetClosureObject(intptr_t num_actual_args) {
|
|
// At a minimum we have the closure object on the stack.
|
|
ASSERT(num_actual_args > 0);
|
|
// Stack pointer points to last argument that was pushed on the stack.
|
|
uword closure_addr = sp() + ((num_actual_args - 1) * kWordSize);
|
|
return reinterpret_cast<RawObject*>(
|
|
*reinterpret_cast<uword*>(closure_addr));
|
|
}
|
|
|
|
|
|
uword CodeBreakpoint::OrigStubAddress() const {
|
|
return saved_value_;
|
|
}
|
|
|
|
|
|
void CodeBreakpoint::PatchCode() {
|
|
ASSERT(!is_enabled_);
|
|
const Code& code = Code::Handle(code_);
|
|
const Instructions& instrs = Instructions::Handle(code.instructions());
|
|
{
|
|
WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
|
|
switch (breakpoint_kind_) {
|
|
case PcDescriptors::kIcCall:
|
|
case PcDescriptors::kUnoptStaticCall:
|
|
case PcDescriptors::kRuntimeCall:
|
|
case PcDescriptors::kClosureCall:
|
|
case PcDescriptors::kReturn: {
|
|
saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
|
|
CodePatcher::PatchStaticCallAt(pc_, code,
|
|
StubCode::BreakpointRuntimeEntryPoint());
|
|
break;
|
|
}
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
is_enabled_ = true;
|
|
}
|
|
|
|
|
|
void CodeBreakpoint::RestoreCode() {
|
|
ASSERT(is_enabled_);
|
|
const Code& code = Code::Handle(code_);
|
|
const Instructions& instrs = Instructions::Handle(code.instructions());
|
|
{
|
|
WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
|
|
switch (breakpoint_kind_) {
|
|
case PcDescriptors::kIcCall:
|
|
case PcDescriptors::kUnoptStaticCall:
|
|
case PcDescriptors::kClosureCall:
|
|
case PcDescriptors::kRuntimeCall:
|
|
case PcDescriptors::kReturn: {
|
|
CodePatcher::PatchStaticCallAt(pc_, code, saved_value_);
|
|
break;
|
|
}
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
is_enabled_ = false;
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_MIPS
|