mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 01:30:32 +00:00
e0112afc70
This test provides very little value. It requests the notification permissions and waits for an answer. What's happening is that the test launches a prompt and then waiting for a user to click on the browser dialog to accept or reject the request. On the bots, this is consistently timing out in chrome and safari. Turns out this issue was [identified][1] 5 years ago and the test was marked as Timeout in the status files for that reason (dart2js) or skipped (DDC). Back then there were discussions about whether we could make chrome automatically accept or reject the request, but there was no traction on that. If we thought this test was providing value, we could explore whether there is a way to make bots automatically accept/reject the prompt by saving some preferences on the test machines. That said, I'm honestly not seeing much value here. For that reason, I'm inclined to delete the test instead. Other reasons to delete mentioned in the review: * this API may require a secure context, but our test runner doesn't default to use https yet * this API requires a [user gesture in FF][2] [1]: https://github.com/dart-lang/sdk/issues/32002 [2]: https://developer.mozilla.org/en-US/docs/Web/API/Notification/requestPermission_static Change-Id: Ib8d372b2ebfb5859a0a9bc82d50a14ad8badeab1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332320 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> |
||
|---|---|---|
| .. | ||
| analyzer | ||
| async | ||
| collection | ||
| convert | ||
| developer | ||
| fix_data_tests | ||
| html | ||
| isolate | ||
| js | ||
| js_interop_unsafe | ||
| math | ||
| mirrors | ||
| typed_data | ||
| web | ||
| lib.status | ||
| lib_analyzer.status | ||
| lib_app_jit.status | ||
| lib_dart2js.status | ||
| lib_dartdevc.status | ||
| lib_kernel.status | ||
| lib_precompiled.status | ||
| lib_vm.status | ||