mirror of
https://github.com/dart-lang/sdk
synced 2024-09-19 14:43:32 +00:00
4b322a398a
1. Run native finalizers before sending isolate exit message. This way users can rely on the isolate exit message for both (1) no Dart code executing anymore on that isolate _and_ (2) all native finalizers having run. Alternatively, we could opt to not provide this second guarantee and document this. 2. Fix UBSAN error by making SetArgumentTo42's argument a `void*`. 3. Fix bug in debug mode, stop reading tags from forwarding addresses. 4. Small optimization: Don't promote 0 bytes from new to old space. 5. Skip finalizer_isolate_groups_run_gc_test in optcounter mode. In hot reload mode, GC is guaranteed to run. On all other bots GC does not run (nothing happens in the other isolate group). However, in optcounter mode enough happens in the other isolate group to trigger GCs. Alternatively, we could loosen the test to allow either a GC to happen or not. TEST=runtime/tests/vm/dart(_2)/finalizer/* TEST=runtime/tests/vm/dart(_2)/isolates/fast_object_copy_test.dart TEST=runtime/vm/object_test.cc TEST=tests/ffi(_2)/vmspecific_native_finalizer_* Closes: https://github.com/dart-lang/sdk/issues/48740 Closes: https://github.com/dart-lang/sdk/issues/48715 Closes: https://github.com/dart-lang/sdk/issues/48674 Change-Id: I5e260e087aef48524f2214f5b332caeda18f2e37 Cq-Include-Trybots: luci.dart.try:vm-kernel-ubsan-linux-release-x64-try,vm-kernel-precomp-ubsan-linux-release-x64-try,vm-canary-linux-debug-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-optcounter-threshold-linux-release-ia32-try,app-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240043 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com> |
||
|---|---|---|
| .. | ||
| array.cc | ||
| async.cc | ||
| async_sources.gni | ||
| bool.cc | ||
| convert_sources.gni | ||
| core_sources.gni | ||
| date.cc | ||
| developer.cc | ||
| developer_sources.gni | ||
| double.cc | ||
| errors.cc | ||
| ffi.cc | ||
| ffi_dynamic_library.cc | ||
| ffi_sources.gni | ||
| function.cc | ||
| growable_array.cc | ||
| identical.cc | ||
| integers.cc | ||
| invocation_mirror.h | ||
| isolate.cc | ||
| isolate_sources.gni | ||
| libgen_in.cc | ||
| math.cc | ||
| math_sources.gni | ||
| mirrors.cc | ||
| mirrors.h | ||
| mirrors_sources.gni | ||
| object.cc | ||
| profiler.cc | ||
| profiler_sources.gni | ||
| regexp.cc | ||
| simd128.cc | ||
| stacktrace.cc | ||
| stacktrace.h | ||
| stopwatch.cc | ||
| string.cc | ||
| timeline.cc | ||
| typed_data.cc | ||
| typed_data_sources.gni | ||
| uri.cc | ||
| vmservice.cc | ||
| vmservice_sources.gni | ||