![]() `Pointer`s were not handled in deferred materialization of objects on deoptimizations. This lead to the address field being written as a tagged value, causing the actual address to be smitagged. Subsequent uses of those addresses would lead to segfaults. This CL handles the `Pointer`s manually to deal with the untagged address. `--trace-deoptimization-verbose` before this CL: ``` Deoptimizing [...] _typedDataBase@8050071 <- Pointer: address=0x7ffff7488081 null Field @ offset(8) <- 140736616678128 null Field @ offset(16) <- TypeArguments: (H39d2e3b4) [Type: Never] ``` after this CL: ``` Deoptimizing [...] _typedDataBase@8050071 <- Pointer: address=0x7fa2c0a88081 pointer@data <- 0x7fa29c16c0e0 pointer@type_args <- TypeArguments: (H39d2e3b4) [Type: Never] ``` TEST=runtime/tests/vm/dart/regress_54871_test.dart TEST=tests/ffi/structs_test.dart with --hot-reload-rollback-test-mode and --optimization-counter-threshold=50 Closes: https://github.com/dart-lang/sdk/issues/54871 Change-Id: I13b6404c8b098643b8ac0f59ee8e9bc635f33b8d Cq-Include-Trybots: luci.dart.try:vm-reload-rollback-linux-debug-x64-try,vm-reload-rollback-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352300 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com> |
||
---|---|---|
.dart_tool | ||
.github | ||
benchmarks | ||
build | ||
docs | ||
pkg | ||
runtime | ||
samples | ||
sdk | ||
tests | ||
third_party | ||
tools | ||
utils | ||
.clang-format | ||
.gitattributes | ||
.gitconfig | ||
.gitignore | ||
.gn | ||
.mailmap | ||
.style.yapf | ||
AUTHORS | ||
BUILD.gn | ||
CHANGELOG.md | ||
codereview.settings | ||
CONTRIBUTING.md | ||
DEPS | ||
LICENSE | ||
OWNERS | ||
PATENT_GRANT | ||
PRESUBMIT.py | ||
README.dart-sdk | ||
README.md | ||
sdk.code-workspace | ||
sdk_args.gni | ||
SECURITY.md | ||
WATCHLISTS |
Dart
An approachable, portable, and productive language for high-quality apps on any platform
Dart is:
-
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
-
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
-
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
-
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
-
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
License & patents
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Using Dart
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
Building Dart
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
Contributing to Dart
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.