languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/pkg
History
Jackson Gardner db214e8c81 Revert "[dart:js_interop] Re-enable type checks on external APIs" 
This reverts commit 2a669c571f.

Reason for revert: Failing dart -> Flutter Engine roller. We need to make some changes on the engine side to prepare for re-enabling these checks.

Original change's description:
> [dart:js_interop] Re-enable type checks on external APIs
>
> External APIs when using dart:js_interop should only allow
> primitives, JS types, and other static interop types. This
> was previously checked in a more restrictive mode called
> "strict mode" but is not checked everywhere where dart:js_interop
> APIs exist.
>
> Change-Id: Ic82a3ec0bf6062c25d7f8933e503820a21bc191f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316867
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Commit-Queue: Srujan Gaddam <srujzs@google.com>

Change-Id: I54caf06976e215b2b576cedfc0013ee79c6682f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324902
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2023-09-11 19:31:20 +00:00
..
_fe_analyzer_shared add declarationKind for extensions and libraries, support augmenting extensions and add test 2023-09-11 15:56:23 +00:00
_js_interop_checks Revert "[dart:js_interop] Re-enable type checks on external APIs" 2023-09-11 19:31:20 +00:00
analysis_server [analysis_server] Add additional tests for file delete/create with overlays 2023-09-11 18:26:15 +00:00
analysis_server_client Extension type. Tests for type hierarchy. 2023-08-30 21:18:25 +00:00
analyzer Augmentation. Support for top-level functions. 2023-09-11 19:08:12 +00:00
analyzer_cli Refactor PubspecValidator 2023-08-16 12:31:30 +00:00
analyzer_plugin Extension type. Create navigation regions for primary constructor and representation field. 2023-09-07 18:20:50 +00:00
analyzer_utilities
async_helper Fix behavior of Stream.empty. 2023-08-17 15:26:59 +00:00
bisect_dart [tool] bisect.dart fix prints 2023-08-25 09:14:40 +00:00
build_integration
compiler [cfe] Embed tearoff in Extension(Type)MemberDescriptor 2023-09-11 13:35:10 +00:00
dap
dart2js_info [dart2js] cleanup backend usage (I) 2023-08-10 22:45:54 +00:00
dart2js_runtime_metrics
dart2js_tools
dart2native [ CLI ] Remove --enable-asserts option for dart compile aot-snapshot 2023-08-24 19:27:29 +00:00
dart2wasm Revert "[dart:js_interop] Re-enable type checks on external APIs" 2023-09-11 19:31:20 +00:00
dart_internal Increase maximum sdk version constraint on dart_internal to 3.3.0 2023-07-27 00:29:42 +00:00
dartdev [dartdev/test] Added missing test case for https://github.com/dart-lang/sdk/issues/52892 2023-09-01 21:05:04 +00:00
dds Update DevTools rev to adfb08c95c626248b28cc60df3b085c12ad8758e 2023-09-08 18:32:51 +00:00
dds_service_extensions
dev_compiler [ddc] Bump pubspec SDK constraint to 3.0.0 2023-09-11 19:07:02 +00:00
expect [dart2js] Add Dart web speciailized expectation helpers. 2023-08-11 20:59:30 +00:00
front_end Revert "[dart:js_interop] Re-enable type checks on external APIs" 2023-09-11 19:31:20 +00:00
frontend_server [dart2wasm] Support for kernel_worker and unevaluated constants. 2023-09-06 18:02:58 +00:00
js
js_ast
js_runtime
js_shared
kernel [cfe] Embed tearoff in Extension(Type)MemberDescriptor 2023-09-11 13:35:10 +00:00
language_versioning_2_7_test
linter [linter] Link to docs for more context on enhanced enums 2023-09-11 17:52:07 +00:00
meta + extension type target kind (and @optionalTypeArgs support) 2023-09-08 18:09:01 +00:00
mmap
modular_test [modular_test] second attempt to fix shards. 2023-07-27 22:29:07 +00:00
native_stack_traces
nnbd_migration [analyzer] Remove all support for strong-mode 2023-08-17 17:07:37 +00:00
scrape [analyzer] Remove unused, old feature methods from old parser 2023-08-15 19:14:17 +00:00
service_extension_router Initial commit for pkg/service_extension_router 2023-08-30 20:18:12 +00:00
smith [dart2wasm,smith] Add options support in test_matrix.json, jscm builder 2023-09-11 10:50:22 +00:00
sourcemap_testing
status_file
telemetry
test_runner [dart2wasm,smith] Add options support in test_matrix.json, jscm builder 2023-09-11 10:50:22 +00:00
testing
vm [cfe] Embed tearoff in Extension(Type)MemberDescriptor 2023-09-11 13:35:10 +00:00
vm_service Avoid passing a nullable value to Completer<nn-type>.completer. 2023-09-06 19:54:00 +00:00
vm_service_protos
vm_snapshot_analysis
wasm_builder [wasm_builder] Fix --watch option to work with instructions 2023-09-07 10:43:49 +00:00
.gitignore
analysis_options.yaml
BUILD.gn
OWNERS
pkg.dart
pkg.status [linter] Only run linter unit tests on the vm runtime 2023-08-23 13:13:47 +00:00
README.md

README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency