dart-sdk/pkg/wasm_builder
Ömer Sinan Ağacan da4bf60a09 [wasm_builder] Update incorrect docs, some minor refactoring
- Imported things (modules, globals, tables, functions) don't need to
  declared before defining things, as we don't assign indices to things
  before finalizing the IR, and when finalizing we assign ids to
  imported things before defined things, in
  `finalizeImportsAndBuilders`.

  Remove documentation saying imports should be declared before
  definitions.

  `FunctionsBuilder._functions` list was used in the name section, and
  required imports to come before definitions. This list is now removed,
  instead we pass `[...imported, ...defined]` to the names section.

- Stop upcasting imported things to `Import` before we need to upcast.

- Fix global lists passed to `NameSection`.

  These lists need to include imports as well (even though we never name
  them, wasm_builder doesn't allow naming them yet) otherwise the
  indices in the name section will be incorrect.

  wasm_builder doesn't allow importing types yet, so we don't need to do
  the same for the types list.

Change-Id: Id05632c3af7937bd66d7581d89d538137020f6e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366601
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2024-05-15 09:49:02 +00:00
..
lib [wasm_builder] Update incorrect docs, some minor refactoring 2024-05-15 09:49:02 +00:00
analysis_options.yaml [pkg/wasm_builder] use package:lints/recommended.yaml 2023-02-13 17:57:24 +00:00
OWNERS
pubspec.yaml [deps] roll package:lints to the latest 2023-10-05 03:36:59 +00:00