mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 04:06:59 +00:00
9fe6571a75
Previously we would specify parameter offset and base register and use SpecialParameter instruction to represent values passed in registers. This CL simplifies and merges these concepts: now every Parameter instruction simply carries around its Location. This CL also tweaks printing of stack slot locations so that they are easier to read: `S+1` becomes `fp[1]` or `sp[1]` depending on the base register, DS+1 becomes `dword fp[1]` / `dword sp[1]` and `QS+1` expands to `qword fp[1]`/`qword sp[1]`. Additionally we clean `BlockBuilder` API a bit - instead of passing `with_frame` to `AddParameter` we make this the property of the builder itself, set at construction time. Issue https://github.com/dart-lang/sdk/issues/54955 Closes https://github.com/dart-lang/sdk/issues/31956 TEST=ci Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-release-arm64-try,vm-aot-linux-release-simarm_x64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-linux-product-x64-try,vm-aot-mac-release-x64-try Change-Id: Ie24dc6b6c47b3a45db722813218bc53c3a06c91d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353081 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Slava Egorov <vegorov@google.com> |
||
|---|---|---|
| .. | ||
| bin | ||
| docs | ||
| include | ||
| lib | ||
| observatory | ||
| platform | ||
| tests | ||
| tools | ||
| vm | ||
| .clang-tidy | ||
| .gitignore | ||
| BUILD.gn | ||
| codereview.settings | ||
| configs.gni | ||
| CPPLINT.cfg | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| runtime_args.gni | ||
| vm-jit.shard.cml | ||
| vm.shard.cml | ||