mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 02:57:35 +00:00
cf7d46097b
Move the method body out of one giant JS foreign function and into Dart code with small JS foreign function calls inside. * Removes the confusion around what it actually means when we use Dart String interpolation within the JS function template. * Highlights the operations that actually need the JS foreign function. * Allows for syntax highlighting and automatic formatting of this code. * Allows for IDE "jump to definition" for class members that were previously inside the template. These changes were developed by diffing the compiled output to ensure the changes were as minimal and inconsequential as possible. The only diffs that appeared beyond the intentional addition of the `t1Bound` and `t2Bound` local variables were: * Using the top level variable for a type: `dart.nullable(core.Object)` -> `T$.ObjectN()` * Loop variable incrementing: `i++` -> `i = i + 1` Change-Id: I55fa3fa94b984c67b18a744837843d458231c4d0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213525 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com> |
||
|---|---|---|
| .. | ||
| bin | ||
| lib | ||
| api_readme.md | ||
| BUILD.gn | ||