cdf35f8782
The change adds a new reduction that recognizes the construction of a type environment from components HTypeBind(HTypeEval(env, e1), HTypeEval(env, e2)) and replace with an equivalent expression that constructs the same derived type environment directly HTypeEval(env, ...e1...e2...) This change speeds up the benchmarks that iterate `Map.entries` by roughly 10-25%. --- Type arguments are passed as separate values [1]. This means that the generative constructor factory `MapEntry<K,V>(this.key, this.value)` has four parameters - `MapEntry$(key, value, $K, $V)`. The passed arguments usually come from the same place, perhaps extracted from the type of the current object, `this.$ti._eval("1")` and `this.$ti._eval("2")`. Inside `MapEntry$`, the type parameters are re-assembled into a type environment: $K._eval("@<0>")._bind($V) which is used to construct the object type $K._eval("@<0>")._bind($V)._eval("MapEntry<1,2>") After inlining: $K = this.$ti._eval("1"); $V = this.$ti._eval("2"); $K._eval("@<0>")._bind($V)._eval("MapEntry<1,2>") After GVN, and reducing the adjacent `._eval("1")._eval("@<0>")` to `._eval("@<1>")`: t1 = this.$ti t1._eval("@<1>")._bind(t1._eval("2"))._eval("MapEntry<1,2>") The new reduction gives us: this.$ti._eval("@<1,2>")._eval("MapEntry<1,2>") which can be reduced further by combining adjacent HTypeEvals: this.$ti._eval("MapEntry<1,2>") [1]: It would be better to pass the type arguments as a single Rti object to avoid the extract-recombine pattern, but changing the calling convention is a more extensive change. In the meantime, this reduction cleans up the extract-recombine pattern when inlining brings the parts together. Change-Id: I28801ce5d952d0f4e5ac1d55c252766159dcceef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367240 Reviewed-by: Mayank Patke <fishythefish@google.com> Commit-Queue: Stephen Adams <sra@google.com> |
||
---|---|---|
.. | ||
_fe_analyzer_shared | ||
_js_interop_checks | ||
_macros | ||
analysis_server | ||
analysis_server_client | ||
analysis_server_plugin | ||
analyzer | ||
analyzer_cli | ||
analyzer_plugin | ||
analyzer_utilities | ||
async_helper | ||
bisect_dart | ||
build_integration | ||
compiler | ||
dart2js_info | ||
dart2js_runtime_metrics | ||
dart2js_tools | ||
dart2native | ||
dart2wasm | ||
dart_internal | ||
dart_service_protocol_shared | ||
dartdev | ||
dds | ||
dds_service_extensions | ||
dev_compiler | ||
dtd | ||
dtd_impl | ||
expect | ||
front_end | ||
frontend_server | ||
heap_snapshot | ||
js | ||
js_ast | ||
js_runtime | ||
js_shared | ||
json | ||
kernel | ||
language_versioning_2_12_test | ||
linter | ||
macros | ||
meta | ||
mmap | ||
modular_test | ||
native_stack_traces | ||
reload_test | ||
scrape | ||
server_plugin | ||
smith | ||
sourcemap_testing | ||
status_file | ||
telemetry | ||
test_runner | ||
testing | ||
vm | ||
vm_service | ||
vm_service_interface | ||
vm_service_protos | ||
vm_snapshot_analysis | ||
wasm_builder | ||
.gitignore | ||
analysis_options.yaml | ||
BUILD.gn | ||
OWNERS | ||
pkg.dart | ||
pkg.status | ||
README.md |
Package validation
The packages in pkg/
are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps
package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/
which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency