languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:10:22 +00:00
Code Issues Projects Releases Packages Wiki Activity
dart-sdk/runtime
History
David Morgan 1d3fbbed7c Revert "Fix duration.toString() to conform the description" 
This reverts commit 038e981f89.

Reason for revert: Breaks some tests; visible changes to some web UIs.

Original change's description:
> Fix duration.toString() to conform the description
> 
> Duration.toString() should return in a format of "HH:MM:SS.mmmmmm".
> But when `hours` is less than 10, toString() doesn't have the leading
> zero, which is "H:MM:SS.mmmmmm".
> 
> The corresponding co19 issue: https://github.com/dart-lang/co19/issues/733
> 
> Bug: https://github.com/dart-lang/sdk/issues/41737
> Change-Id: I2264171b2b37e89056695f7f821125a5f78d87fb
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151163
> Commit-Queue: Zichang Guo <zichangguo@google.com>
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

TBR=lrn@google.com,zichangguo@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/41737
Change-Id: I4d7ef5de9807e8e2b2a77c2171d1693b7527f671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151848
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
2020-06-22 10:29:15 +00:00
..
bin Revert "Reland : [VM/Runtime] Cleanup package config initialization code" 2020-06-20 08:02:53 +00:00
docs
include Revert "Reland : [VM/Runtime] Cleanup package config initialization code" 2020-06-20 08:02:53 +00:00
lib [vm/nnbd] Non-null assertions in NNBD weak mode 2020-06-18 20:02:42 +00:00
llvm_codegen
observatory
platform Reland "Revert "Add an --os=fuchsia option to build.py:"" 2020-06-18 00:24:31 +00:00
tests/vm [vm/aot] Reland "Keep column information when possible for precompiled mode." 2020-06-19 13:50:03 +00:00
third_party Reland "[vm] Build dart2native dependencies with the normal "create_sdk" target" 2020-06-17 16:12:26 +00:00
tools
vm Revert "Fix duration.toString() to conform the description" 2020-06-22 10:29:15 +00:00
.clang-tidy
.gitignore
BUILD.gn [vm/ffi] Expose a subset of dart_(native_)api.h for dynamic linking. 2020-06-18 07:30:43 +00:00
codereview.settings
configs.gni Reland "[vm] Build dart2native dependencies with the normal "create_sdk" target" 2020-06-17 16:12:26 +00:00
CPPLINT.cfg
PRESUBMIT.py
runtime_args.gni