mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 11:58:13 +00:00
a5e1f89583
IsolateData contains AppSnapshot which might own some HeapPage-s, so we can't destroy IsolateData in the Dart_IsolateShutdownCallback, because some thread running in the isolate (e.g. background compiler) might still touch thoses pages or objects they host. We need to delay destruction of AppSnapshot until after the isolate shutdown. Current API does not allow that, so we introduce a new isolate lifecycle callback - Dart_IsolateCleanupCallback, which is invoked at the end of the isolote lifecycle when things like background compiler have been stopped and no Dart code is supposed to run. BUG= R=rmacnak@google.com Review-Url: https://codereview.chromium.org/2720723005 .
55 lines
1.4 KiB
C++
55 lines
1.4 KiB
C++
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "bin/isolate_data.h"
|
|
#include "bin/snapshot_utils.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
IsolateData::IsolateData(const char* url,
|
|
const char* package_root,
|
|
const char* packages_file,
|
|
AppSnapshot* app_snapshot)
|
|
: script_url((url != NULL) ? strdup(url) : NULL),
|
|
package_root(NULL),
|
|
packages_file(NULL),
|
|
udp_receive_buffer(NULL),
|
|
builtin_lib_(NULL),
|
|
loader_(NULL),
|
|
app_snapshot_(app_snapshot),
|
|
dependencies_(NULL) {
|
|
if (package_root != NULL) {
|
|
ASSERT(packages_file == NULL);
|
|
this->package_root = strdup(package_root);
|
|
} else if (packages_file != NULL) {
|
|
this->packages_file = strdup(packages_file);
|
|
}
|
|
}
|
|
|
|
|
|
void IsolateData::OnIsolateShutdown() {
|
|
if (builtin_lib_ != NULL) {
|
|
Dart_DeletePersistentHandle(builtin_lib_);
|
|
builtin_lib_ = NULL;
|
|
}
|
|
}
|
|
|
|
|
|
IsolateData::~IsolateData() {
|
|
free(script_url);
|
|
script_url = NULL;
|
|
free(package_root);
|
|
package_root = NULL;
|
|
free(packages_file);
|
|
packages_file = NULL;
|
|
free(udp_receive_buffer);
|
|
udp_receive_buffer = NULL;
|
|
delete app_snapshot_;
|
|
app_snapshot_ = NULL;
|
|
}
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|