mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 04:27:17 +00:00
db90fd784b
Remove the `@DontInline()` annotation. None of the backends implemented
it. (Searching for "DontInline" yields nothing in our code base.)
Instead replaced the use sites with `@pragma('vm:never-inline')` and
`@pragma('dart2js:noInline')`, which are implemented in the backends.
Original suggestion:
https://dart-review.googlesource.com/c/sdk/+/208080/4..6/tests/language_2/const/map_hashcode_override_test.dart#b11
Change-Id: Ifdcfc8ef3413d0b5964edc1bc1fa47c5ce306935
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208082
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
33 lines
838 B
Dart
33 lines
838 B
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
// Regression test for dart2js that used to generate wrong code for
|
|
// [foo].
|
|
|
|
import "package:expect/expect.dart";
|
|
|
|
main() {
|
|
var result = foo(1, 2);
|
|
Expect.equals(1, result[0]);
|
|
Expect.equals(2, result[1]);
|
|
|
|
result = foo([], 2);
|
|
Expect.equals(0, result[0]);
|
|
Expect.listEquals([], result[1]);
|
|
}
|
|
|
|
@pragma('vm:never-inline')
|
|
@pragma('dart2js:noInline')
|
|
foo(a, b) {
|
|
() => 42;
|
|
if (a is List) {
|
|
var saved = a as List;
|
|
// By having two HTypeKnown SSA instructions for [a], dart2js was
|
|
// confused when updating the phis at exit of this block.
|
|
a = a.length;
|
|
b = saved;
|
|
}
|
|
return [a, b];
|
|
}
|