mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 04:27:17 +00:00
db90fd784b
Remove the `@DontInline()` annotation. None of the backends implemented
it. (Searching for "DontInline" yields nothing in our code base.)
Instead replaced the use sites with `@pragma('vm:never-inline')` and
`@pragma('dart2js:noInline')`, which are implemented in the backends.
Original suggestion:
https://dart-review.googlesource.com/c/sdk/+/208080/4..6/tests/language_2/const/map_hashcode_override_test.dart#b11
Change-Id: Ifdcfc8ef3413d0b5964edc1bc1fa47c5ce306935
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208082
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
66 lines
1.5 KiB
Dart
66 lines
1.5 KiB
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
// Regression test for dart2js that used to optimistically infer the
|
|
// wrong types for fields because of generative constructors being
|
|
// inlined.
|
|
|
|
import "package:expect/expect.dart";
|
|
|
|
class A {
|
|
var foo;
|
|
var bar;
|
|
|
|
@pragma('vm:never-inline')
|
|
@pragma('dart2js:noInline')
|
|
A() {
|
|
// Currently defeat inlining by using a closure.
|
|
bar = () => 42;
|
|
foo = 54;
|
|
}
|
|
A.inline();
|
|
}
|
|
|
|
main() {
|
|
// Make sure A's constructor is analyzed first by surrounding the
|
|
// body by two allocations.
|
|
new A();
|
|
bar();
|
|
new A();
|
|
}
|
|
|
|
class B {
|
|
var bar;
|
|
var closure;
|
|
@pragma('vm:never-inline')
|
|
@pragma('dart2js:noInline')
|
|
B() {
|
|
// Currently defeat inlining by using a closure.
|
|
closure = () => 42;
|
|
bar = new A().foo;
|
|
}
|
|
}
|
|
|
|
@pragma('vm:never-inline')
|
|
@pragma('dart2js:noInline')
|
|
bar() {
|
|
// Make sure B's constructor is analyzed first by surrounding the
|
|
// body by two allocations.
|
|
new B();
|
|
// Currently defeat inlining by using a closure.
|
|
Expect.throwsNoSuchMethodError(() => new A.inline().foo + 42);
|
|
codegenLast();
|
|
new B();
|
|
}
|
|
|
|
@pragma('vm:never-inline')
|
|
@pragma('dart2js:noInline')
|
|
codegenLast() {
|
|
// This assignment currently defeats simple type inference, but not
|
|
// the optimistic inferrer.
|
|
new A().foo = new B().bar;
|
|
// Currently defeat inlining by using a closure.
|
|
new B().closure = () => 42;
|
|
}
|