mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 04:37:12 +00:00
efdffab8b7
This fixes an issue where VM would run the async* generator after a `yield` / `yield*` even though the subscription may be paused or cancelled. Furthermore this fixes an issue where `StackTrace.current` used in async* generator crashes VM and/or produces truncated stack trace. This fixes the following existing tests that were failing before: * co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_t08 * co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_t09 * co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_t10 * language/async_star/async_star_cancel_test * language/async_star/pause_test New in reland: Allow the generator to to cause cancelling it's own consumer. This addresses the issue of original revert -> see https://github.com/flutter/flutter/issues/101514 Issue https://github.com/flutter/flutter/issues/100441 Issue https://github.com/dart-lang/sdk/issues/48695 Issue https://github.com/dart-lang/sdk/issues/34775 TEST=vm/dart{,_2}/causal_stacks/flutter_regress_100441_test Change-Id: I091b7159d59ea15fc31162b4b6b17260d523d7cb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242400 Reviewed-by: Lasse Nielsen <lrn@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
100 lines
2.1 KiB
Dart
100 lines
2.1 KiB
Dart
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:async_helper/async_minitest.dart';
|
|
|
|
import 'utils.dart';
|
|
|
|
main() {
|
|
test('pauses execution at yield for at least a microtask', () {
|
|
var list = [];
|
|
f() async* {
|
|
list.add(1);
|
|
yield 2;
|
|
list.add(3);
|
|
yield 4;
|
|
list.add(5);
|
|
}
|
|
|
|
var done = Completer();
|
|
var sub = f().listen((v) {
|
|
if (v == 2) {
|
|
expect(list, equals([1]));
|
|
} else if (v == 4) {
|
|
expect(list, equals([1, 3]));
|
|
} else {
|
|
fail('Unexpected value $v');
|
|
}
|
|
}, onDone: () {
|
|
expect(list, equals([1, 3, 5]));
|
|
done.complete();
|
|
});
|
|
return done.future;
|
|
});
|
|
|
|
test('pause stops execution at yield', () {
|
|
var list = [];
|
|
f() async* {
|
|
list.add(1);
|
|
yield 2;
|
|
list.add(3);
|
|
yield 4;
|
|
list.add(5);
|
|
}
|
|
|
|
var done = Completer();
|
|
var sub;
|
|
sub = f().listen((v) {
|
|
if (v == 2) {
|
|
expect(list, equals([1]));
|
|
sub.pause();
|
|
Timer(ms * 300, () {
|
|
expect(list.length, lessThan(3));
|
|
sub.resume();
|
|
});
|
|
} else if (v == 4) {
|
|
expect(list, equals([1, 3]));
|
|
} else {
|
|
fail('Unexpected value $v');
|
|
}
|
|
}, onDone: () {
|
|
expect(list, equals([1, 3, 5]));
|
|
done.complete();
|
|
});
|
|
return done.future;
|
|
});
|
|
|
|
test('pause stops execution at yield 2', () {
|
|
var list = [];
|
|
f() async* {
|
|
int i = 0;
|
|
while (true) {
|
|
list.add(i);
|
|
yield i;
|
|
i++;
|
|
}
|
|
}
|
|
|
|
int expected = 0;
|
|
var done = Completer();
|
|
var sub;
|
|
sub = f().listen((v) {
|
|
expect(v, equals(expected++));
|
|
if (v % 5 == 0) {
|
|
sub.pause(Future.delayed(ms * 300));
|
|
} else if (v == 17) {
|
|
sub.cancel();
|
|
done.complete();
|
|
}
|
|
}, onDone: () {
|
|
fail('Unexpected done!');
|
|
});
|
|
return done.future.whenComplete(() {
|
|
expect(list.length == 18 || list.length == 19, isTrue);
|
|
});
|
|
});
|
|
}
|