dart-sdk/sdk_nnbd/lib
Alexander Markov c798bd8e53 [vm/nnbd] Fix element type nullability check in _GrowableList.length=
When growing an array, we're checking if element type is nullable.
The problem is that 'null is! T' is true for legacy types T
(other than top types and Null), so it throws for List<int*>.

In order to be able to grow arrays with all element types which can
hold null (including legacy element types) this test is changed to

      null as T;

which throws type error if T cannot hold null.

Change-Id: Icf0a397109945b049b4aaead4c7eab11d903c45b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134790
Reviewed-by: Liam Appelbe <liama@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2020-02-07 17:32:24 +00:00
..
_http [nnbd] Fix remaining NNBD errors in dart:_http and dart:io. 2020-02-07 14:31:09 +00:00
_internal [vm/nnbd] Fix element type nullability check in _GrowableList.length= 2020-02-07 17:32:24 +00:00
async Migrate language_2/assert to NNBD. 2020-02-06 22:47:25 +00:00
cli [VM/libraries] - Fix signature of waitFor. 2020-02-05 22:48:50 +00:00
collection Stop using List() constructor in NNBD code. 2020-01-24 15:59:29 +00:00
convert Fix based64 decoder. 2020-01-31 19:00:32 +00:00
core Updating iterable.current comments and behavior to be consistent. 2020-01-24 17:35:39 +00:00
developer [test] Run some service tests in AOT. 2020-01-23 17:52:40 +00:00
ffi [vm/ffi] Migrate dart:ffi to nnbd 2020-01-15 09:47:44 +00:00
html DOM script changes to handle nnbd 2020-02-07 01:05:14 +00:00
indexed_db/dart2js DOM script changes to handle nnbd 2020-02-07 01:05:14 +00:00
internal Updating iterable.current comments and behavior to be consistent. 2020-01-24 17:35:39 +00:00
io [nnbd] Fix SecureServerSocket not allowing null SecurityContext. 2020-02-07 13:36:03 +00:00
isolate [VM/patch libraries] - Fix analyzer errors/warnings. 2020-01-18 02:37:08 +00:00
js [nnbd] remove opt-out for dart:_js 2020-01-22 21:39:56 +00:00
js_util [nnbd] port dart:js_util to nnbd 2020-01-17 01:19:35 +00:00
math Update math.dart:atan2 in relation to atan comment - Follow-up for sdk_nnbd 2019-12-16 12:49:27 +00:00
mirrors [lib] Be explicit about the type parameter for positional argument lists. 2020-01-22 21:36:03 +00:00
svg/dart2js DOM script changes to handle nnbd 2020-02-07 01:05:14 +00:00
typed_data Update typed-data constructor documentation. 2020-01-24 09:53:26 +00:00
vmservice [ VM / Service ] Fix service/developer_server_control_test which was broken after vmservice NNBD migration 2020-02-07 00:45:09 +00:00
wasm [vm, library] Migrate dart:wasm to NNBD 2020-01-14 17:55:55 +00:00
web_audio/dart2js DOM script changes to handle nnbd 2020-02-07 01:05:14 +00:00
web_gl/dart2js DOM script changes to handle nnbd 2020-02-07 01:05:14 +00:00
web_sql/dart2js DOM script changes to handle nnbd 2020-02-07 01:05:14 +00:00
libraries.json [VM/Libraries] Use the NNBD libraries when building the NNBD sdk. 2020-02-07 00:00:07 +00:00
libraries.yaml [VM/Libraries] Use the NNBD libraries when building the NNBD sdk. 2020-02-07 00:00:07 +00:00
vmservice_libraries.json [ VM / dart:vmservice ] Migrate dart:vmservice to NNBD, cleanup outdated code 2020-01-15 01:00:34 +00:00
vmservice_libraries.yaml [ VM / dart:vmservice ] Migrate dart:vmservice to NNBD, cleanup outdated code 2020-01-15 01:00:34 +00:00