mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 17:56:11 +00:00
c771931f6b
I recently fixed a bug by adding a `sink.done.ignore()` into library code: https://dart-review.googlesource.com/c/sdk/+/351380 My thinking now is that is a bad idea because it allows errors to pass silently if the sink is not closed or flushed (and the results are awaited!). Instead, we should document this as a general pattern for sinks. ...but that isn't satisfying either. `sink.done.ignore()` really means "I promise that I will handle errors elsewhere" but there is no actual enforcement of that. Bug:https://github.com/dart-lang/sdk/issues/54707 Change-Id: I92feb43b1b2c57933c2343f4b6d354792cd13d72 CoreLibraryReviewExempt: dart io documentation-only Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352442 Commit-Queue: Brian Quinlan <bquinlan@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com> |
||
|---|---|---|
| .. | ||
| bin | ||
| lib | ||
| .gitignore | ||
| api_readme.md | ||
| BUILD.gn | ||
| OWNERS | ||