mirror of
https://github.com/dart-lang/sdk
synced 2024-11-02 12:20:38 +00:00
8dbf923e89
`hashCode` requires that equal objects have the same hash code.
However it doesn't (and cannot) require that inequal objects have
different hash codes. Remove the invalid check.
This makes the test pass on dart2wasm, which currently implements
closure hash code as:
// Simple hash code for now, we can optimize later
@override
int get hashCode => runtimeType.hashCode;
Note: this change alone does not make the whole file pass with
dart2wasm, there's another (unrelated) issue which will be fixed
separately.
Change-Id: Ibc83aee13fdbe48d1b2f7d8e720766b455c6b930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286783
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
|
||
|---|---|---|
| .. | ||
| co19 | ||
| co19_2 | ||
| corelib | ||
| corelib_2 | ||
| dartdevc | ||
| dartdevc_2 | ||
| ffi | ||
| ffi_2 | ||
| language | ||
| language_2 | ||
| lib | ||
| lib_2 | ||
| modular | ||
| standalone | ||
| standalone_2 | ||
| web | ||
| web_2 | ||
| legacy_status_dart2js.csv | ||
| OWNERS | ||
| README.md | ||
This directory contains tests of the language and core library implementations. For more information, see https://github.com/dart-lang/sdk/wiki/Testing.