dart-sdk/pkg
Derek Xu c09f790d37 [VM/CLI] Remove dartdev.dill
Incompatible VM flags will no longer break the CLI when running from an
AppJIT snapshot, so the fallback logic is no longer required. This CL
thus removes dartdev.dill and the fallback logic.

Relevant past CLs: https://dart-review.googlesource.com/c/sdk/+/157601
and https://dart-review.googlesource.com/c/sdk/+/178300

Fixes https://github.com/dart-lang/sdk/issues/50504

TEST=I tried running `out/ReleaseX64/dart --observe --sound-null-safety test.dart`
and `out/ReleaseX64/dart --observe --no-sound-null-safety test.dart` and
both worked.

Change-Id: I5cdcfbccf71ec557964014fdb80733b4a7c76b4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274520
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
2022-12-12 18:02:47 +00:00
..
_fe_analyzer_shared Flow analysis: add assertions to AssignedVariables.declare. 2022-12-12 17:05:23 +00:00
_js_interop_checks
analysis_server
analysis_server_client
analyzer Flow analysis: add assertions to AssignedVariables.declare. 2022-12-12 17:05:23 +00:00
analyzer_cli
analyzer_plugin
analyzer_utilities
async_helper
build_integration
compiler
dart2js_info
dart2js_runtime_metrics
dart2js_tools
dart2native
dart2wasm
dart_internal
dartdev [VM/CLI] Remove dartdev.dill 2022-12-12 18:02:47 +00:00
dds
dds_service_extensions
dev_compiler
expect
front_end Flow analysis: add assertions to AssignedVariables.declare. 2022-12-12 17:05:23 +00:00
frontend_server
js
js_ast
js_runtime
js_shared
kernel
language_versioning_2_7_test
meta
modular_test
native_stack_traces
nnbd_migration
scrape
smith
sourcemap_testing
status_file
telemetry
test_runner
testing
vm
vm_service
vm_snapshot_analysis
wasm_builder
.gitignore
BUILD.gn
OWNERS
pkg.status
README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency