mirror of
https://github.com/dart-lang/sdk
synced 2024-10-15 00:28:05 +00:00
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
91 lines
2.7 KiB
C++
91 lines
2.7 KiB
C++
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_THREAD_STATE_H_
|
|
#define RUNTIME_VM_THREAD_STATE_H_
|
|
|
|
#include "include/dart_api.h"
|
|
#include "vm/os_thread.h"
|
|
|
|
namespace dart {
|
|
|
|
class HandleScope;
|
|
class LongJumpScope;
|
|
class Zone;
|
|
|
|
// ThreadState is a container for auxiliary thread-local state: e.g. it
|
|
// owns a stack of Zones for allocation and a stack of StackResources
|
|
// for stack unwinding.
|
|
//
|
|
// Important: this class is shared between compiler and runtime and
|
|
// as such it should not expose any runtime internals due to layering
|
|
// restrictions.
|
|
class ThreadState : public BaseThread {
|
|
public:
|
|
// The currently executing thread, or nullptr if not yet initialized.
|
|
static ThreadState* Current() { return OSThread::CurrentVMThread(); }
|
|
|
|
explicit ThreadState(bool is_os_thread);
|
|
virtual ~ThreadState();
|
|
|
|
// OSThread corresponding to this thread.
|
|
OSThread* os_thread() const { return os_thread_; }
|
|
void set_os_thread(OSThread* os_thread) { os_thread_ = os_thread; }
|
|
|
|
// The topmost zone used for allocation in this thread.
|
|
Zone* zone() const { return zone_; }
|
|
|
|
bool ZoneIsOwnedByThread(Zone* zone) const;
|
|
|
|
StackResource* top_resource() const { return top_resource_; }
|
|
void set_top_resource(StackResource* value) { top_resource_ = value; }
|
|
static intptr_t top_resource_offset() {
|
|
return OFFSET_OF(ThreadState, top_resource_);
|
|
}
|
|
|
|
LongJumpScope* long_jump_base() const { return long_jump_base_; }
|
|
void set_long_jump_base(LongJumpScope* value) { long_jump_base_ = value; }
|
|
|
|
bool IsValidZoneHandle(Dart_Handle object) const;
|
|
intptr_t CountZoneHandles() const;
|
|
bool IsValidScopedHandle(Dart_Handle object) const;
|
|
intptr_t CountScopedHandles() const;
|
|
|
|
virtual bool MayAllocateHandles() = 0;
|
|
|
|
HandleScope* top_handle_scope() const {
|
|
#if defined(DEBUG)
|
|
return top_handle_scope_;
|
|
#else
|
|
return 0;
|
|
#endif
|
|
}
|
|
|
|
void set_top_handle_scope(HandleScope* handle_scope) {
|
|
#if defined(DEBUG)
|
|
top_handle_scope_ = handle_scope;
|
|
#endif
|
|
}
|
|
|
|
private:
|
|
void set_zone(Zone* zone) { zone_ = zone; }
|
|
|
|
OSThread* os_thread_ = nullptr;
|
|
Zone* zone_ = nullptr;
|
|
StackResource* top_resource_ = nullptr;
|
|
LongJumpScope* long_jump_base_ = nullptr;
|
|
|
|
// This field is only used in the DEBUG builds, but we don't exclude it
|
|
// because it would cause RELEASE and DEBUG builds to have different
|
|
// offsets for various Thread fields that are used from generated code.
|
|
HandleScope* top_handle_scope_ = nullptr;
|
|
|
|
friend class ApiZone;
|
|
friend class StackZone;
|
|
};
|
|
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_VM_THREAD_STATE_H_
|