mirror of
https://github.com/dart-lang/sdk
synced 2024-10-15 00:04:55 +00:00
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
144 lines
3.2 KiB
C++
144 lines
3.2 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include <utility>
|
|
|
|
#include "platform/assert.h"
|
|
#include "vm/growable_array.h"
|
|
#include "vm/symbols.h"
|
|
#include "vm/unit_test.h"
|
|
|
|
namespace dart {
|
|
|
|
template <class GrowableArrayInt, class GrowableArrayInt64>
|
|
void TestGrowableArray() {
|
|
GrowableArrayInt g;
|
|
EXPECT_EQ(0, g.length());
|
|
EXPECT(g.is_empty());
|
|
g.Add(5);
|
|
EXPECT_EQ(5, g[0]);
|
|
EXPECT_EQ(1, g.length());
|
|
EXPECT(!g.is_empty());
|
|
g.Add(3);
|
|
const GrowableArrayInt& temp = g;
|
|
EXPECT_EQ(5, temp[0]);
|
|
EXPECT_EQ(3, temp[1]);
|
|
for (int i = 0; i < 10000; i++) {
|
|
g.Add(i);
|
|
}
|
|
EXPECT_EQ(10002, g.length());
|
|
EXPECT_EQ(10000 - 1, g.Last());
|
|
|
|
GrowableArrayInt64 f(10);
|
|
EXPECT_EQ(0, f.length());
|
|
f.Add(-1LL);
|
|
f.Add(15LL);
|
|
EXPECT_EQ(2, f.length());
|
|
for (int64_t l = 0; l < 100; l++) {
|
|
f.Add(l);
|
|
}
|
|
EXPECT_EQ(102, f.length());
|
|
EXPECT_EQ(100 - 1, f.Last());
|
|
EXPECT_EQ(-1LL, f[0]);
|
|
|
|
GrowableArrayInt h;
|
|
EXPECT_EQ(0, h.length());
|
|
h.Add(101);
|
|
h.Add(102);
|
|
h.Add(103);
|
|
EXPECT_EQ(3, h.length());
|
|
EXPECT_EQ(103, h.Last());
|
|
h.RemoveLast();
|
|
EXPECT_EQ(2, h.length());
|
|
EXPECT_EQ(102, h.Last());
|
|
h.RemoveLast();
|
|
EXPECT_EQ(1, h.length());
|
|
EXPECT_EQ(101, h.Last());
|
|
h.RemoveLast();
|
|
EXPECT_EQ(0, h.length());
|
|
EXPECT(h.is_empty());
|
|
h.Add(-8899);
|
|
h.Add(7908);
|
|
EXPECT(!h.is_empty());
|
|
h.Clear();
|
|
EXPECT(h.is_empty());
|
|
}
|
|
|
|
TEST_CASE(GrowableArray) {
|
|
TestGrowableArray<GrowableArray<int>, GrowableArray<int64_t> >();
|
|
}
|
|
|
|
TEST_CASE(MallocGrowableArray) {
|
|
TestGrowableArray<MallocGrowableArray<int>, MallocGrowableArray<int64_t> >();
|
|
}
|
|
|
|
static int greatestFirst(const int* a, const int* b) {
|
|
if (*a > *b) {
|
|
return -1;
|
|
} else if (*a < *b) {
|
|
return 1;
|
|
} else {
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
TEST_CASE(GrowableArraySort) {
|
|
GrowableArray<int> g;
|
|
g.Add(12);
|
|
g.Add(4);
|
|
g.Add(64);
|
|
g.Add(8);
|
|
g.Sort(greatestFirst);
|
|
EXPECT_EQ(64, g[0]);
|
|
EXPECT_EQ(4, g.Last());
|
|
}
|
|
|
|
ISOLATE_UNIT_TEST_CASE(GrowableHandlePtr) {
|
|
Zone* zone = Thread::Current()->zone();
|
|
GrowableHandlePtrArray<const String> test1(zone, 1);
|
|
EXPECT_EQ(0, test1.length());
|
|
test1.Add(Symbols::Int());
|
|
EXPECT(test1[0].ptr() == Symbols::Int().ptr());
|
|
EXPECT_EQ(1, test1.length());
|
|
|
|
ZoneGrowableHandlePtrArray<const String>* test2 =
|
|
new ZoneGrowableHandlePtrArray<const String>(zone, 1);
|
|
test2->Add(Symbols::GetterPrefix());
|
|
EXPECT((*test2)[0].ptr() == Symbols::GetterPrefix().ptr());
|
|
EXPECT_EQ(1, test2->length());
|
|
}
|
|
|
|
TEST_CASE(GrowableArrayMoveCtor) {
|
|
GrowableArray<int> a;
|
|
a.Add(4);
|
|
a.Add(5);
|
|
int* a_data = a.data();
|
|
|
|
GrowableArray<int> b(std::move(a));
|
|
|
|
EXPECT_EQ(0, a.length());
|
|
EXPECT_EQ((int*)nullptr, a.data());
|
|
EXPECT_EQ(2, b.length());
|
|
EXPECT_EQ(a_data, b.data());
|
|
}
|
|
|
|
TEST_CASE(GrowableArrayMoveAssign) {
|
|
GrowableArray<int> a, b;
|
|
a.Add(1);
|
|
a.Add(2);
|
|
a.Add(3);
|
|
b.Add(7);
|
|
int* a_data = a.data();
|
|
int* b_data = b.data();
|
|
|
|
a = std::move(b);
|
|
|
|
EXPECT_EQ(1, a.length());
|
|
EXPECT_EQ(b_data, a.data());
|
|
EXPECT_EQ(3, b.length());
|
|
EXPECT_EQ(a_data, b.data());
|
|
}
|
|
|
|
} // namespace dart
|