dart-sdk/tests/standalone_2
Slava Egorov 8b6e39696f [vm/io] Avoid leaking Handle::data_ready_ on Windows.
Handle::data_ready_ contains bytes which are ready to be sent to Dart
side. Not all code paths fully drain this buffer and delete it
before destroying the handle, for example directory watch implementation
was prone to leaking data_ready_ when subscription was cancelled.

This CL switches the code to use unique_ptr to hold on to data_ready_
which makes sure that it is deleted when Handle is destroyed.

The code would benefit from holding all OverlappedBuffer instances
through unique_ptr but that is a much larger refactoring which
we leave for a later date.

Fixes https://github.com/dart-lang/sdk/issues/52715

TEST=standalone{,_2}/regress_52715_test

Bug: 52715
Cq-Include-Trybots: luci.dart.try:vm-win-release-x64-try,vm-win-debug-x64-try,vm-aot-win-release-x64-try,analyzer-win-release-try
Change-Id: Ie8d728b823de7e8f9de1489898e270580c2af269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311841
Commit-Queue: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Slava Egorov <vegorov@google.com>
2023-06-28 13:06:51 +00:00
..
deferred Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
http_launch_data [CFE] Remove support for .packages file 2022-06-24 08:20:39 +00:00
io [vm/io] Fix standalone/io/client_socket_add_destroy_no_error_test 2023-06-09 18:14:53 +00:00
package [CFE] Remove support for .packages file 2022-06-24 08:20:39 +00:00
array_bounds_check_generalization_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
assert_assignable_canon_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
byte_array_view_optimized_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
bytedata_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
check_class_cha_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
check_for_aot_snapshot_jit_test.dart [3.0 alpha][VM/Runtime] - Flip flag to make strong null safety the default. 2022-12-06 04:04:23 +00:00
check_null_cha_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
constant_left_shift_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
deferred_transitive_import_error_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
deny_listed_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
deoptimization_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
double_hash_distribution_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
double_smi_comparison_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
double_temp_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
double_to_int_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
dwarf_stack_trace_invisible_functions_test.dart [gardening] Fix dwarf_stack_trace_invisible_functions_test 2023-05-03 23:01:48 +00:00
dwarf_stack_trace_obfuscate_test.dart [infra] Prevent VM AOT tests from poluting SDK source. 2023-05-03 13:24:39 +00:00
dwarf_stack_trace_test.dart [infra] Prevent VM AOT tests from poluting SDK source. 2023-05-03 13:24:39 +00:00
env_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
float_array_static_test.dart Migrate standalone tests off @compile-error. 2023-04-19 14:17:39 +00:00
float_array_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
fragmentation_deferred_load_lib1.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
fragmentation_deferred_load_lib2.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
fragmentation_deferred_load_lib3.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
fragmentation_deferred_load_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
fragmentation_test.dart [vm, gc] Add option to madvise(DONTNEED) when sweeping. 2023-06-07 19:01:51 +00:00
fragmentation_typed_data_test.dart [vm, gc] Add option to madvise(DONTNEED) when sweeping. 2023-06-07 19:01:51 +00:00
http_launch_test.dart [CFE] Remove support for .packages file 2022-06-24 08:20:39 +00:00
int_array_deopt.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
int_array_load_elimination_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
int_array_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
int_list_test.dart [tests] Avoid small --optimization-counter-threshold in tests 2022-10-10 21:04:18 +00:00
lazy_async_stack_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
left_shift_bit_and_op_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
link_natives_lazily_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
map_insert_remove_oom_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
medium_integer_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_allow_absolute_addresses_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_lazy_dispatchers_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_profiler_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_such_method_error_with_invocation_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_support_ast_printer_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_support_debugger_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_support_disassembler_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_support_il_printer_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_support_service_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
no_support_timeline_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
number_identity_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
oom_error_stacktrace_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
out_of_memory_recovery_synchronous_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
out_of_memory_recovery_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
out_of_memory_slow_growth_test.dart [test] Avoid tests fighting over the default service port. 2022-11-10 17:28:48 +00:00
out_of_memory_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
out_of_memory_unhandled_exception_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
packages_file_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
pair_location_remapping_test.dart Spelling tests 2022-12-19 12:56:47 +00:00
pow_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
priority_queue_stress_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
regress31114_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
regress_25335_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
regress_26031_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
regress_28854_1_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
regress_28854_2_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
regress_29350_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
regress_29695_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
regress_41329_absolute_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
regress_41329_relative_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
regress_42092_script.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
regress_42092_test.dart [ VM ] Add delay between SIGINTs to fix flakiness of regress_42092_test 2021-06-29 01:36:32 +00:00
regress_52715_test.dart [vm/io] Avoid leaking Handle::data_ready_ on Windows. 2023-06-28 13:06:51 +00:00
slowpath_safepoints_test.dart [tests] Avoid small --optimization-counter-threshold in tests 2022-10-10 21:04:18 +00:00
standalone_2.status [test] Misc dart:io test fixes. 2023-04-05 19:15:19 +00:00
standalone_2_analyzer.status Delete standalone_2/io/process_exit_negative_test.dart. 2019-11-19 18:23:30 +00:00
standalone_2_kernel.status Fix HTTPS client certificate test 2023-04-26 06:45:20 +00:00
standalone_2_precompiled.status [VM/io] - Reland : Set correct file type for files backing unix domain sockets 2022-05-15 00:40:07 +00:00
standalone_2_vm.status [test] Introduce status variable $simulator, and fix some cases missing simarm_x64. 2023-04-04 03:10:26 +00:00
string_overflow_test.dart [gardening] Fix string_overflow_test.dart 2021-06-04 14:38:16 +00:00
typed_array_int64_uint64_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
typed_array_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
typed_data_isolate_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
typed_data_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
typed_data_view_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
unboxed_int_converter_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00
verbose_gc_to_bmu_script.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
verbose_gc_to_bmu_test.dart Add language versions to _2 test libraries 2021-04-26 17:58:57 +00:00