dart-sdk/tests/standalone
Slava Egorov 8b6e39696f [vm/io] Avoid leaking Handle::data_ready_ on Windows.
Handle::data_ready_ contains bytes which are ready to be sent to Dart
side. Not all code paths fully drain this buffer and delete it
before destroying the handle, for example directory watch implementation
was prone to leaking data_ready_ when subscription was cancelled.

This CL switches the code to use unique_ptr to hold on to data_ready_
which makes sure that it is deleted when Handle is destroyed.

The code would benefit from holding all OverlappedBuffer instances
through unique_ptr but that is a much larger refactoring which
we leave for a later date.

Fixes https://github.com/dart-lang/sdk/issues/52715

TEST=standalone{,_2}/regress_52715_test

Bug: 52715
Cq-Include-Trybots: luci.dart.try:vm-win-release-x64-try,vm-win-debug-x64-try,vm-aot-win-release-x64-try,analyzer-win-release-try
Change-Id: Ie8d728b823de7e8f9de1489898e270580c2af269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311841
Commit-Queue: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Slava Egorov <vegorov@google.com>
2023-06-28 13:06:51 +00:00
..
deferred
http_launch_data
io Ensure HttpClient.setTimelineLogging does not throw an exception in 2023-06-22 01:16:45 +00:00
package [CFE] Remove support for .packages file 2022-06-24 08:20:39 +00:00
stack_trace
array_bounds_check_generalization_test.dart
assert_assignable_canon_test.dart
byte_array_view_optimized_test.dart
bytedata_test.dart
check_class_cha_test.dart
check_for_aot_snapshot_jit_test.dart [3.0 alpha][VM/Runtime] - Flip flag to make strong null safety the default. 2022-12-06 04:04:23 +00:00
check_null_cha_test.dart
constant_left_shift_test.dart
deferred_transitive_import_error_test.dart
deny_listed_test.dart
deoptimization_test.dart
double_hash_distribution_test.dart
double_smi_comparison_test.dart
double_temp_test.dart
double_to_int_test.dart
dwarf_stack_trace_invisible_functions_test.dart [infra] Prevent VM AOT tests from poluting SDK source. 2023-05-03 13:24:39 +00:00
dwarf_stack_trace_obfuscate_test.dart [infra] Prevent VM AOT tests from poluting SDK source. 2023-05-03 13:24:39 +00:00
dwarf_stack_trace_test.dart [infra] Prevent VM AOT tests from poluting SDK source. 2023-05-03 13:24:39 +00:00
env_test.dart
float_array_static_test.dart Migrate standalone tests off @compile-error. 2023-04-19 14:17:39 +00:00
float_array_test.dart
fragmentation_deferred_load_lib1.dart
fragmentation_deferred_load_lib2.dart
fragmentation_deferred_load_lib3.dart
fragmentation_deferred_load_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
fragmentation_test.dart [vm, gc] Add option to madvise(DONTNEED) when sweeping. 2023-06-07 19:01:51 +00:00
fragmentation_typed_data_test.dart [vm, gc] Add option to madvise(DONTNEED) when sweeping. 2023-06-07 19:01:51 +00:00
gn_py_test.dart Reland "[build] Handle cases for dart_target_arch != target_arch and target_cpu != host_cpu." 2023-03-22 14:57:27 +00:00
http_launch_test.dart
int_array_deopt.dart
int_array_load_elimination_test.dart
int_array_test.dart
int_list_test.dart [tests] Avoid small --optimization-counter-threshold in tests 2022-10-10 21:04:18 +00:00
lazy_async_stack_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
left_shift_bit_and_op_test.dart
link_natives_lazily_test.dart
map_insert_remove_oom_test.dart
medium_integer_test.dart
no_allow_absolute_addresses_test.dart
no_lazy_dispatchers_test.dart
no_profiler_test.dart
no_such_method_error_with_invocation_test.dart
no_support_ast_printer_test.dart
no_support_debugger_test.dart
no_support_disassembler_test.dart
no_support_il_printer_test.dart
no_support_service_test.dart
no_support_timeline_test.dart
number_identity_test.dart
oom_error_stacktrace_test.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
out_of_memory_recovery_synchronous_test.dart
out_of_memory_recovery_test.dart
out_of_memory_slow_growth_test.dart [test] Avoid tests fighting over the default service port. 2022-11-10 17:28:48 +00:00
out_of_memory_test.dart
out_of_memory_unhandled_exception_test.dart
packages_file_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
pair_location_remapping_test.dart Spelling tests 2022-12-19 12:56:47 +00:00
pie_test.dart Reland "[build, vm] Access TLS with less code." 2023-03-02 23:07:16 +00:00
pow_test.dart
priority_queue_stress_test.dart Remove uses of : as default value separator in some tests/ directories. 2022-09-07 14:49:17 +00:00
regress31114_test.dart
regress_25335_test.dart
regress_26031_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
regress_28854_1_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
regress_28854_2_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
regress_29350_test.dart
regress_29695_test.dart
regress_41329_absolute_test.dart
regress_41329_relative_test.dart
regress_42092_script.dart
regress_42092_test.dart [ VM ] Add delay between SIGINTs to fix flakiness of regress_42092_test 2021-06-29 01:36:32 +00:00
regress_52715_test.dart [vm/io] Avoid leaking Handle::data_ready_ on Windows. 2023-06-28 13:06:51 +00:00
slowpath_safepoints_test.dart [tests] Avoid small --optimization-counter-threshold in tests 2022-10-10 21:04:18 +00:00
standalone.status [gardening] Update status files after starting to run tests in obfucated/dwarf nnbd mode 2023-04-21 10:13:57 +00:00
standalone_analyzer.status
standalone_kernel.status Fix HTTPS client certificate test 2023-04-26 06:45:20 +00:00
standalone_precompiled.status [VM/io] - Reland : Set correct file type for files backing unix domain sockets 2022-05-15 00:40:07 +00:00
standalone_vm.status Fix Socket remoteAddress obtaining on Win32 #51778 2023-06-07 19:32:49 +00:00
string_overflow_test.dart [gardening] Fix string_overflow_test.dart 2021-06-04 14:38:16 +00:00
typed_array_int64_uint64_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
typed_array_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
typed_data_isolate_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
typed_data_test.dart
typed_data_view_test.dart
unboxed_int_converter_test.dart
verbose_gc_to_bmu_script.dart [3.0 alpha] Remove deprecated dart:core List() constructor. 2022-12-15 11:36:22 +00:00
verbose_gc_to_bmu_test.dart