mirror of
https://github.com/dart-lang/sdk
synced 2024-09-06 00:59:09 +00:00
c771931f6b
I recently fixed a bug by adding a `sink.done.ignore()` into library code: https://dart-review.googlesource.com/c/sdk/+/351380 My thinking now is that is a bad idea because it allows errors to pass silently if the sink is not closed or flushed (and the results are awaited!). Instead, we should document this as a general pattern for sinks. ...but that isn't satisfying either. `sink.done.ignore()` really means "I promise that I will handle errors elsewhere" but there is no actual enforcement of that. Bug:https://github.com/dart-lang/sdk/issues/54707 Change-Id: I92feb43b1b2c57933c2343f4b6d354792cd13d72 CoreLibraryReviewExempt: dart io documentation-only Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352442 Commit-Queue: Brian Quinlan <bquinlan@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com> |
||
|---|---|---|
| .. | ||
| common.dart | ||
| data_transformer.dart | ||
| directory.dart | ||
| directory_impl.dart | ||
| embedder_config.dart | ||
| eventhandler.dart | ||
| file.dart | ||
| file_impl.dart | ||
| file_system_entity.dart | ||
| io.dart | ||
| io_resource_info.dart | ||
| io_service.dart | ||
| io_sink.dart | ||
| io_sources.gni | ||
| link.dart | ||
| namespace_impl.dart | ||
| network_profiling.dart | ||
| overrides.dart | ||
| platform.dart | ||
| platform_impl.dart | ||
| process.dart | ||
| secure_server_socket.dart | ||
| secure_socket.dart | ||
| security_context.dart | ||
| service_object.dart | ||
| socket.dart | ||
| stdio.dart | ||
| string_transformer.dart | ||
| sync_socket.dart | ||