mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 16:41:07 +00:00
7e8a203f1e
This test returned a future, which in other runtimes may mean that the test would not be awaited for. The test-runner for DDC does include extra asyncStart/asyncEnd to ensure the test runs to completion. However, this sporadically caused double reporting and flaky failures ([example][1]). This change makes the test itself track the async nature of the test, just like we do in most other tests today. [1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766055193681740753/+/u/test_results/ignored_flaky_test_failure_logs Change-Id: Ib0edab197db21026d38b40036a1eeaf6edff5ad6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333300 Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> |
||
|---|---|---|
| .. | ||
| cast_error | ||
| debugger | ||
| mixin | ||
| assertion_failure_message_test.dart | ||
| basic_assignment_test.dart | ||
| const_test.dart | ||
| developer_events_test.dart | ||
| hot_restart_expando_test.dart | ||
| hot_restart_js_interop_test.dart | ||
| hot_restart_late_test.dart | ||
| hot_restart_static_test.dart | ||
| hot_restart_test.dart | ||
| hot_restart_timer_test.dart | ||
| if_else_literal_compilation_test.dart | ||
| js_interop_non_external_lib.dart | ||
| js_interop_non_external_test.dart | ||
| js_interop_test.dart | ||
| libraries_part.dart | ||
| libraries_test.dart | ||
| no_such_method_errors_test.dart | ||
| regress52688_test.dart | ||
| runtime_utils.dart | ||
| runtime_utils_nnbd.dart | ||
| subtype_test.dart | ||
| subtype_weak_test.dart | ||
| type_normalization_test.dart | ||
| utils.dart | ||
| variance_subtype_test.dart | ||
| variance_test.dart | ||
| weak_null_safety_errors_test.dart | ||