mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 03:17:55 +00:00
ad2708d071
The Dart2JS team has agreed that this mode of compilation is no longer worth investing in at this time and its existence adds some overhead to other feature work so it is worth fully removing. In the future we may revisit this mode of compilation. Below is some more context for any future exploration in this space. What didn't work with modular analysis: - current modular analysis was computing impacts, which were dense (50% of the size of kernel) - using it moved work to a modular phase, and cut Phase1 in half however end-to-end time was not better - data overhead was very high - it made it much harder to maintain invariants throughout the pipeline: the data is tightly coupled with the kernel AST, making it hard to make late modifications to the AST. How to potentially make it better: - make the data much more sparse - make the data more independent from the kernel AST so that transformations are not breaking - reduce the critical path in a more substantial way. Note: We retain and ignore the commandline flags used for modular analysis in order to avoid breaking build pipelines that were passing them. We may remove these at a later date. Change-Id: If574ce2358280ab5fedd89c62665328601e72e22 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333360 Reviewed-by: Mayank Patke <fishythefish@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Nate Biggs <natebiggs@google.com> |
||
|---|---|---|
| .. | ||
| kernel_visitor | ||
| null_safety | ||
| used_names | ||
| dart2js_profile_many.dart | ||
| dart2js_stress.dart | ||
| graph_isomorphizer.dart | ||
| hot_reload_launcher.dart | ||
| modular_dart2js.dart | ||
| modular_test_suite.dart | ||
| modular_test_suite_helper.dart | ||
| szcmp | ||
| track_memory.dart | ||
| update_id_tests.dart | ||