mirror of
https://github.com/dart-lang/sdk
synced 2024-07-20 06:56:09 +00:00
ad2708d071
The Dart2JS team has agreed that this mode of compilation is no longer worth investing in at this time and its existence adds some overhead to other feature work so it is worth fully removing. In the future we may revisit this mode of compilation. Below is some more context for any future exploration in this space. What didn't work with modular analysis: - current modular analysis was computing impacts, which were dense (50% of the size of kernel) - using it moved work to a modular phase, and cut Phase1 in half however end-to-end time was not better - data overhead was very high - it made it much harder to maintain invariants throughout the pipeline: the data is tightly coupled with the kernel AST, making it hard to make late modifications to the AST. How to potentially make it better: - make the data much more sparse - make the data more independent from the kernel AST so that transformations are not breaking - reduce the critical path in a more substantial way. Note: We retain and ignore the commandline flags used for modular analysis in order to avoid breaking build pipelines that were passing them. We may remove these at a later date. Change-Id: If574ce2358280ab5fedd89c62665328601e72e22 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333360 Reviewed-by: Mayank Patke <fishythefish@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Nate Biggs <natebiggs@google.com> |
||
|---|---|---|
| .. | ||
| _fe_analyzer_shared | ||
| _js_interop_checks | ||
| analysis_server | ||
| analysis_server_client | ||
| analyzer | ||
| analyzer_cli | ||
| analyzer_plugin | ||
| analyzer_utilities | ||
| async_helper | ||
| bisect_dart | ||
| build_integration | ||
| compiler | ||
| dap | ||
| dart2js_info | ||
| dart2js_runtime_metrics | ||
| dart2js_tools | ||
| dart2native | ||
| dart2wasm | ||
| dart_internal | ||
| dartdev | ||
| dds | ||
| dds_service_extensions | ||
| dev_compiler | ||
| expect | ||
| front_end | ||
| frontend_server | ||
| heap_snapshot | ||
| js | ||
| js_ast | ||
| js_runtime | ||
| js_shared | ||
| kernel | ||
| language_versioning_2_7_test | ||
| linter | ||
| meta | ||
| mmap | ||
| modular_test | ||
| native_stack_traces | ||
| nnbd_migration | ||
| scrape | ||
| service_extension_router | ||
| smith | ||
| sourcemap_testing | ||
| status_file | ||
| telemetry | ||
| test_runner | ||
| testing | ||
| vm | ||
| vm_service | ||
| vm_service_interface | ||
| vm_service_protos | ||
| vm_snapshot_analysis | ||
| wasm_builder | ||
| .gitignore | ||
| analysis_options.yaml | ||
| BUILD.gn | ||
| OWNERS | ||
| pkg.dart | ||
| pkg.status | ||
| README.md | ||
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency