ad06d73ace
The current two-level indexing scheme for function type parameters (depth and index) breaks down in the case of type substitution when the substituted type is a generic function type, since its internal type parameter types have been encoded assuming that the function type had nesting depth zero, but after substitution its nesting depth can be higher. Relative indexing schemes such as De Bruijn indices will also not work, since function type parameter types are constant types, and the constant infrastructure assumes that the same constant always has the same representation. This change introduces a flat indexing scheme where function type parameters are indexed using a single index which is independent of the context in which the type parameter type appears. To avoid collisions in the case of nested generic function types, every function type has a type parameter offset, which conceptually shifts the indexing range of its type parameters so it doesn't necessarily start at zero. Looking up a function type parameter in its environment thus involves searching outwards until a function type is found whose type parameter index range contains the index encoded in the function type parameter type. Change-Id: I544056d52711ff829b170f78a7274a93871825a4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272361 Reviewed-by: Joshua Litt <joshualitt@google.com> |
||
|---|---|---|
| .. | ||
| _fe_analyzer_shared | ||
| _js_interop_checks | ||
| analysis_server | ||
| analysis_server_client | ||
| analyzer | ||
| analyzer_cli | ||
| analyzer_plugin | ||
| analyzer_utilities | ||
| async_helper | ||
| build_integration | ||
| compiler | ||
| dart2js_info | ||
| dart2js_runtime_metrics | ||
| dart2js_tools | ||
| dart2native | ||
| dart2wasm | ||
| dart_internal | ||
| dartdev | ||
| dds | ||
| dds_service_extensions | ||
| dev_compiler | ||
| expect | ||
| front_end | ||
| frontend_server | ||
| js | ||
| js_ast | ||
| js_runtime | ||
| js_shared | ||
| kernel | ||
| language_versioning_2_7_test | ||
| meta | ||
| modular_test | ||
| native_stack_traces | ||
| nnbd_migration | ||
| scrape | ||
| smith | ||
| sourcemap_testing | ||
| status_file | ||
| telemetry | ||
| test_runner | ||
| testing | ||
| vm | ||
| vm_service | ||
| vm_snapshot_analysis | ||
| wasm_builder | ||
| .gitignore | ||
| BUILD.gn | ||
| OWNERS | ||
| pkg.status | ||
| README.md | ||
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency