![]() This is a non-functional refactor that extracts the growing set of capabilities and options from ServerCapabilitiesComputer into files alongside the handlers they relate to. The motivation for this is that for LSP-over-Legacy we'll need to accept client capabilities (and return server capabilities). The server capabilities will be different to the standard LSP ones (they will be a subset, and we might not support dynamic registration - at least initially). However the features we do support will have the same registration options, so to avoid duplicating them this moves the registration options away from the creation of the ServerCapabilities. In future, we might consider further wrapping up a "feature" (which consists of these registration options, and the related handlers), but this change is already quite large and I just wanted to progress capabilities for LSP-over-Legacy so we can handle things like Code Actions (which require executeCommand and possible reverse-requests for applyEdit). Change-Id: Iecd0aa36626fa44826f7d4dbd6e6c0d758075239 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319840 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> |
||
---|---|---|
.. | ||
_fe_analyzer_shared | ||
_js_interop_checks | ||
analysis_server | ||
analysis_server_client | ||
analyzer | ||
analyzer_cli | ||
analyzer_plugin | ||
analyzer_utilities | ||
async_helper | ||
bisect_dart | ||
build_integration | ||
compiler | ||
dap | ||
dart2js_info | ||
dart2js_runtime_metrics | ||
dart2js_tools | ||
dart2native | ||
dart2wasm | ||
dart_internal | ||
dartdev | ||
dds | ||
dds_service_extensions | ||
dev_compiler | ||
expect | ||
front_end | ||
frontend_server | ||
js | ||
js_ast | ||
js_runtime | ||
js_shared | ||
kernel | ||
language_versioning_2_7_test | ||
meta | ||
mmap | ||
modular_test | ||
native_stack_traces | ||
nnbd_migration | ||
scrape | ||
smith | ||
sourcemap_testing | ||
status_file | ||
telemetry | ||
test_runner | ||
testing | ||
vm | ||
vm_service | ||
vm_service_protos | ||
vm_snapshot_analysis | ||
wasm_builder | ||
.gitignore | ||
analysis_options.yaml | ||
BUILD.gn | ||
OWNERS | ||
pkg.dart | ||
pkg.status | ||
README.md |
Package validation
The packages in pkg/
are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps
package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/
which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency