mirror of
https://github.com/dart-lang/sdk
synced 2024-11-02 10:49:00 +00:00
81f6cc144e
In case the environment is incorrectly set on Windows (e.g. GYP_MSVS_OVERRIDE_PATH pointing to a non-existing path), the setup_toolchain.py script may raise an exception. The script attempts to run a subprocess to gather the environment variables. But it does not check that the process actually succeeded. In case the process fails the environment data will be invalid and the script will ultimately raise an exception. This change adds a check for the process failing, and gracefully warns and exits the script instead. TEST=Manual build on Windows. Change-Id: I3624bdf98e0ebe48b403825a90ce2e86c2ed8008 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242860 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Tess Strickland <sstrickl@google.com> |
||
|---|---|---|
| .. | ||
| config | ||
| dart | ||
| fuchsia | ||
| linux | ||
| mac | ||
| rust | ||
| sanitizers | ||
| secondary/third_party | ||
| toolchain | ||
| win | ||
| .gitignore | ||
| detect_host_arch.py | ||
| executable_suffix.gni | ||
| gn_helpers.py | ||
| gn_run_binary.py | ||
| OWNERS | ||
| README.dart.md | ||
| vs_toolchain.py | ||
This directory was taken from a snapshot of flutter/engine/src/build/.
The snapshot was taken with a recursive copy cp -R of the directory from
the flutter repository.
The contents has now diverged significantly from Flutter, and is maintained independently by the Dart team. It is used to support the GN build system.