mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 01:30:32 +00:00
a7104c813f
These tests check for lowerbounds on the time it took to fire an event. Unfortunately, browsers may complete events ahead of time. This has caused these tests to be flaky in dart2js and ddc [1] In a local experiment, we've seen timers complete +-15ms from the expected time. Most often they are around +-5ms, but those more extreme cases do happen. Recent flakiness logs show some good samples: * off by 1ms: [2] and [3] * off by 4ms: [4] * off by 13ms: [5] This CL makes two adjustments to reduce flakiness: * account for the fact that timers may complete early (checking that they are >= than the expected timeout - 40ms) * increase intervals to 50ms in order to prevent overlap between two events in the worse scenario that both happen on the extreme variances (+15ms and -15ms respectively). [1]: https://dart-current-results.web.app/#/filter=lib/async/periodic_timer,dart2js,ddc&showAll [2]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766776511992750881/+/u/test_results/ignored_flaky_test_failure_logs [3]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766798962026535617/+/u/test_results/ignored_flaky_test_failure_logs [4]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767378609439308945/+/u/test_results/ignored_flaky_test_failure_logs [5]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767357850408867553/+/u/test_results/ignored_flaky_test_failure_logs Change-Id: Ib46d6f33f5c2b1458f393e8b4c75c84453e73024 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331210 Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> |
||
|---|---|---|
| .. | ||
| analyzer | ||
| async | ||
| collection | ||
| convert | ||
| developer | ||
| fix_data_tests | ||
| html | ||
| isolate | ||
| js | ||
| js_interop_unsafe | ||
| math | ||
| mirrors | ||
| typed_data | ||
| web | ||
| lib.status | ||
| lib_analyzer.status | ||
| lib_app_jit.status | ||
| lib_dart2js.status | ||
| lib_dartdevc.status | ||
| lib_kernel.status | ||
| lib_precompiled.status | ||
| lib_vm.status | ||