languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/runtime
History
Paul Berry 9e3842d624 Observatory strong mode fix: fix type errors with onDisconnect. 
The method ObservatoryApplication._switchVM calls newVM.onDisconnect
and requires the resulting future to be completed with a String.  In
normal operation, this is satisfied and we just need to change a few
static types to enforce it.  But when FakeVM was in use, the future
was completed with `this`.  Since ObservatoryApplication._switchVM is
the only call site that cares what the future is completed with, it
makes sense to just change all the types to Future<String> and modify
FakeVM accordingly.

Change-Id: Id94d27ac6a42f31ab19ccc9ad8dd270ecf4042b4
Reviewed-on: https://dart-review.googlesource.com/57400
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-05-30 20:50:24 +00:00
..
bin Reland "[vm] Support definition of entry-points via @pragma('vm.extern') annotations."" 2018-05-30 20:06:40 +00:00
include Reapply "[mirrors] Add IsolateMirror.loadUri." 2018-05-29 22:01:01 +00:00
lib [vm/corelib] Remove GrowableArrayMarker hack. 2018-05-30 13:44:43 +00:00
observatory Observatory strong mode fix: fix type errors with onDisconnect. 2018-05-30 20:50:24 +00:00
platform [ VM / Build ] Added '--no-include-kernel-service' to build.py. By default, the kernel service is now included in all build modes, including product mode. Providing '--no-include-kernel-service' will build the specified configuration without the kernel service. 2018-05-23 20:35:53 +00:00
tests/vm Revert "[vm] Add tests for determinism of script and AppJIT snapshots." 2018-05-30 00:53:08 +00:00
third_party [gn] Split target arch/os defines from dart_config 2017-10-31 17:33:13 +00:00
tools [Observatory] Refactor observatory build to prepare for Fuchsia prebuilt 2018-05-29 16:35:34 +00:00
vm [VM] Fix for issue 33277 (skip HasAttemptedReload check for kernel 2018-05-30 20:14:45 +00:00
.gitignore
BUILD.gn [ VM / Build ] Added '--no-include-kernel-service' to build.py. By default, the kernel service is now included in all build modes, including product mode. Providing '--no-include-kernel-service' will build the specified configuration without the kernel service. 2018-05-23 20:35:53 +00:00
codereview.settings
configs.gni [windows] Fix 'all' target 2018-05-14 22:17:38 +00:00
CPPLINT.cfg
PRESUBMIT.py
runtime_args.gni [ VM / Build ] Added '--no-include-kernel-service' to build.py. By default, the kernel service is now included in all build modes, including product mode. Providing '--no-include-kernel-service' will build the specified configuration without the kernel service. 2018-05-23 20:35:53 +00:00