mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 18:16:04 +00:00
a52f2b9617
The main contribution of this CL is unification of disparate handling of various functions like `Future.timeout`, `Future.wait`, `_SuspendState.createAsyncCallbacks` and `_SuspendState._createAsyncStarCallback` into a single `@pragma('vm:awaiter-link')` which allows Dart developers to specify where awaiter unwinder should look for the next awaiter. For example this allows unwinding to succeed for the code like this: Future<int> outer(Future<int> inner) { @pragma('vm:awaiter-link') final completer = Completer<int>(); inner.then((v) => completer.complete(v)); return completer.future; } This refactoring also ensures that we preserve information (including Function & Code objects) required for awaiter unwinding across all modes (JIT, AOT and AOT with DWARF stack traces). This guarantees users will get the same information no matter which mode they are running in. Previously we have been disabling awaiter_stacks tests in some AOT modes - which led to regressions in the quality of produced stacks. This CL also cleans up relationship between debugger and awaiter stack returned by StackTrace.current - which makes stack trace displayed by debugger (used for stepping out and determinining whether exception is caught or not) and `StackTrace.current` consistent. Finally we make one user visible change to the stack trace: awaiter stack will no always include intermediate listeners created through `Future.then`. Previously we would sometimes include these listeners at the tail of the stack trace, which was inconsistent. Ultimately this means that code like this: Future<int> inner() async { await null; // asynchronous gap print(StackTrace.current); // (*) return 0; } Future<int> outer() async { int process(int v) { return v + 1; } return await inner().then(process); } void main() async { await outer(); } Produces stack trace like this: inner <asynchronous suspension> outer.process <asynchronous suspension> outer <asynchronous suspension> main <asynchronous suspension> And when stepping out of `inner` execution will stop at `outer.process` first and the next step out will bring execution to `outer` next. Fixes https://github.com/dart-lang/sdk/issues/52797 Fixes https://github.com/dart-lang/sdk/issues/52203 Issue https://github.com/dart-lang/sdk/issues/47985 TEST=ci Bug: b/279929839 CoreLibraryReviewExempt: CL just adds @pragma to facilitate unwinding Cq-Include-Trybots: luci.dart.try:vm-aot-linux-product-x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-dwarf-linux-product-x64-try Change-Id: If377d5329d6a11c86effb9369dc603a7ae616fe7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311680 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Slava Egorov <vegorov@google.com> |
||
---|---|---|
.. | ||
_http | ||
_internal | ||
_wasm | ||
async | ||
cli | ||
collection | ||
convert | ||
core | ||
developer | ||
ffi | ||
html | ||
indexed_db/dart2js | ||
internal | ||
io | ||
isolate | ||
js | ||
js_interop | ||
js_interop_unsafe | ||
js_util | ||
math | ||
mirrors | ||
svg/dart2js | ||
typed_data | ||
vmservice | ||
web_audio/dart2js | ||
web_gl/dart2js | ||
web_sql/dart2js | ||
analysis_options.yaml | ||
libraries.json | ||
libraries.yaml | ||
PRESUBMIT.py | ||
vmservice_libraries.json | ||
vmservice_libraries.yaml |