languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/runtime
History
Siva Annamalai b5aeaa6796 Revert "Reland "[vm/ffi] SimDBC on Arm64 Android"" 
This reverts commit a515a0c256.

Reason for revert: There are still issues here, the flutter engine build for ios_debug again fails with this error:
ld: warning: arm64 function not 4-byte aligned: FfiTrampolineCall from obj/third_party/dart/runtime/vm/compiler/libdart_vm_jit.ffi_dbc_trampoline_arm64.o
ld: warning: arm64 function not 4-byte aligned: .loop from obj/third_party/dart/runtime/vm/compiler/libdart_vm_jit.ffi_dbc_trampoline_arm64.o
ld: warning: arm64 function not 4-byte aligned: .done from obj/third_party/dart/runtime/vm/compiler/libdart_vm_jit.ffi_dbc_trampoline_arm64.o
Undefined symbols for architecture arm64:
  "_FfiTrampolineCall", referenced from:
      dart::Simulator::Call(dart::Code const&, dart::Array const&, dart::Array const&, dart::Thread*) in libdart_vm_jit.simulator_dbc.o
ld: symbol(s) not found for architecture arm64

Original change's description:
> Reland "[vm/ffi] SimDBC on Arm64 Android"
> 
> This reverts commit 0abff7b2bb and fixes the assembly file.
> 
> Change-Id: Ibef58c932c843aebb4de227ac5fc7664d463173f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107746
> Auto-Submit: Daco Harkes <dacoharkes@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>
> Commit-Queue: Daco Harkes <dacoharkes@google.com>

TBR=sjindel@google.com,asiva@google.com,dacoharkes@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia5fd52180f7d9dfce588db361ce17dfb6f05254d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108206
Reviewed-by: Siva Annamalai <asiva@google.com>
2019-07-04 00:57:23 +00:00
..
bin Revert "Reland "[vm/concurrency] Introduce concept of Isolate Groups"" 2019-07-03 12:19:15 +00:00
docs Move the test runner (i.e. "test.dart"/"test.py") to pkg/. 2019-06-14 23:35:10 +00:00
include Revert "Reland "[vm/concurrency] Introduce concept of Isolate Groups"" 2019-07-03 12:19:15 +00:00
lib Revert "Reland "[vm/concurrency] Introduce concept of Isolate Groups"" 2019-07-03 12:19:15 +00:00
observatory [ VM / Observatory ] Emit IsolateReload event after reload completes 2019-07-03 20:40:37 +00:00
platform [vm] Cleanup C99 header includes 2019-07-03 10:54:24 +00:00
tests/vm Skip all tests that use spawnUri when running in simulator mode as it makes no sense to run the CFE on the simulator. 2019-07-02 17:32:23 +00:00
third_party [vm, fuchsia] Fix deps and stop suppressing -fvisibility=hidden. 2019-04-29 23:31:27 +00:00
tools [vm] Cleanup C99 header includes 2019-07-03 10:54:24 +00:00
vm Revert "Reland "[vm/ffi] SimDBC on Arm64 Android"" 2019-07-04 00:57:23 +00:00
.gitignore
BUILD.gn [vm/bytecode] Bootstrapping VM from bytecode 2019-06-26 18:25:26 +00:00
codereview.settings
configs.gni [vm, fuchsia] Fix deps and stop suppressing -fvisibility=hidden. 2019-04-29 23:31:27 +00:00
CPPLINT.cfg
PRESUBMIT.py Fix PRESUBMIT.py so it is python3-compatible. 2019-05-07 20:53:06 +00:00
runtime_args.gni [vm/bytecode] Enable building of kernel service snapshot 2019-04-05 22:31:58 +00:00