mirror of
https://github.com/dart-lang/sdk
synced 2024-09-19 20:41:45 +00:00
1f55b7ca10
This is a reland of 8a21ab195a
Original change's description:
> [VM/runtime] Refactor the representation of type parameters in the VM.
>
> This introduces a new VM internal class 'TypeParameters' representing the declaration of a list of type parameters, either in a class or function.
> The reference to (or use of) a type parameter is still represented by the existing 'TypeParameter' class.
>
> Fixes https://github.com/dart-lang/sdk/issues/43901
> Fixes https://github.com/dart-lang/sdk/issues/45763
>
> TEST=existing ones and a regression test
>
> Change-Id: I1fde808bf753cc1cb829f2c4383c1836651cee80
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189942
> Commit-Queue: Régis Crelier <regis@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
This fixes https://github.com/dart-lang/sdk/issues/45911
TEST=existing ones and a regression test
Change-Id: I709d38b1df3d73fe3c9796d5aca3cbbdcf77fd38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198380
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
73 lines
3.1 KiB
C++
73 lines
3.1 KiB
C++
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/canonical_tables.h"
|
|
|
|
namespace dart {
|
|
|
|
bool MetadataMapTraits::IsMatch(const Object& a, const Object& b) {
|
|
// In the absence of hot reload, this can just be an identity check. With
|
|
// reload, some old program elements may be retained by the stack, closures
|
|
// or mirrors, which are absent from the new version of the library's
|
|
// metadata table. This name-based matching fuzzy maps the old program
|
|
// elements to corresponding new elements, preserving the behavior of the old
|
|
// metaname+fields scheme.
|
|
if (a.IsLibrary() && b.IsLibrary()) {
|
|
const String& url_a = String::Handle(Library::Cast(a).url());
|
|
const String& url_b = String::Handle(Library::Cast(b).url());
|
|
return url_a.Equals(url_b);
|
|
} else if (a.IsClass() && b.IsClass()) {
|
|
const String& name_a = String::Handle(Class::Cast(a).Name());
|
|
const String& name_b = String::Handle(Class::Cast(b).Name());
|
|
return name_a.Equals(name_b);
|
|
} else if (a.IsFunction() && b.IsFunction()) {
|
|
const String& name_a = String::Handle(Function::Cast(a).name());
|
|
const String& name_b = String::Handle(Function::Cast(b).name());
|
|
if (!name_a.Equals(name_b)) {
|
|
return false;
|
|
}
|
|
const Object& owner_a = Object::Handle(Function::Cast(a).Owner());
|
|
const Object& owner_b = Object::Handle(Function::Cast(b).Owner());
|
|
return IsMatch(owner_a, owner_b);
|
|
} else if (a.IsField() && b.IsField()) {
|
|
const String& name_a = String::Handle(Field::Cast(a).name());
|
|
const String& name_b = String::Handle(Field::Cast(b).name());
|
|
if (!name_a.Equals(name_b)) {
|
|
return false;
|
|
}
|
|
const Object& owner_a = Object::Handle(Field::Cast(a).Owner());
|
|
const Object& owner_b = Object::Handle(Field::Cast(b).Owner());
|
|
return IsMatch(owner_a, owner_b);
|
|
} else if (a.IsTypeParameter() && b.IsTypeParameter()) {
|
|
if (TypeParameter::Cast(a).index() != TypeParameter::Cast(b).index() ||
|
|
TypeParameter::Cast(a).base() != TypeParameter::Cast(b).base()) {
|
|
return false;
|
|
}
|
|
return TypeParameter::Cast(a).parameterized_class_id() ==
|
|
TypeParameter::Cast(b).parameterized_class_id();
|
|
}
|
|
return a.ptr() == b.ptr();
|
|
}
|
|
|
|
uword MetadataMapTraits::Hash(const Object& key) {
|
|
if (key.IsLibrary()) {
|
|
return String::Hash(Library::Cast(key).url());
|
|
} else if (key.IsClass()) {
|
|
return String::Hash(Class::Cast(key).Name());
|
|
} else if (key.IsFunction()) {
|
|
return CombineHashes(String::Hash(Function::Cast(key).name()),
|
|
Hash(Object::Handle(Function::Cast(key).Owner())));
|
|
} else if (key.IsField()) {
|
|
return CombineHashes(String::Hash(Field::Cast(key).name()),
|
|
Hash(Object::Handle(Field::Cast(key).Owner())));
|
|
} else if (key.IsTypeParameter()) {
|
|
return TypeParameter::Cast(key).Hash();
|
|
} else if (key.IsNamespace()) {
|
|
return Hash(Library::Handle(Namespace::Cast(key).target()));
|
|
}
|
|
UNREACHABLE();
|
|
}
|
|
|
|
} // namespace dart
|