mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 10:33:28 +00:00
a37c34b5fb
Some tests are run via createCommand, some via computeCompilationArtifact. This meant that some tests got an environment and some didn't, resulting in the batch workers getting restarted all the time. This CL fixes the issue by passing the environment to createCommand as well, meaning that the batch workers doesn't restart unnecessarily. Before: $ cls; xvfb-run -a '--server-args=-screen 0 1024x768x24' python -u ./tools/test.py -mrelease --checked --strong --use-sdk -rchrome -cdartdevk language_2 [03:09 | 100% | + 5171 | - 0] $ cls; xvfb-run -a '--server-args=-screen 0 1024x768x24' python -u ./tools/test.py -mrelease --checked --strong --use-sdk -rchrome -cdartdevc language_2 [02:33 | 100% | + 5170 | - 0] Now: $ cls; xvfb-run -a '--server-args=-screen 0 1024x768x24' python -u ./tools/test.py -mrelease --checked --strong --use-sdk -rchrome -cdartdevk language_2 [01:41 | 100% | + 5171 | - 0] $ cls; xvfb-run -a '--server-args=-screen 0 1024x768x24' python -u ./tools/test.py -mrelease --checked --strong --use-sdk -rchrome -cdartdevc language_2 [01:59 | 100% | + 5170 | - 0] I.e. dartdevk tests are now almost twice as fast (on my machine). Bug: Change-Id: I15111436d3411b6ba85209950e4a5f20ee515539 Reviewed-on: https://dart-review.googlesource.com/29100 Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Jens Johansen <jensj@google.com> |
||
---|---|---|
build | ||
client | ||
docs | ||
pkg | ||
runtime | ||
samples | ||
samples-dev | ||
sdk | ||
tests | ||
third_party | ||
tools | ||
utils | ||
.clang-format | ||
.gitattributes | ||
.gitignore | ||
.gn | ||
.mailmap | ||
.packages | ||
AUTHORS | ||
BUILD.gn | ||
CHANGELOG.md | ||
codereview.settings | ||
DEPS | ||
LICENSE | ||
PATENTS | ||
PRESUBMIT.py | ||
README.dart-sdk | ||
README.md | ||
WATCHLISTS |
Dart
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Using Dart
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
Building Dart
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
Contributing to Dart
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.