mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 01:30:32 +00:00
e1834792c3
Fixes https://github.com/dart-lang/sdk/issues/55024 The patch files for these operators return a bool, whereas the public API returns a JSBoolean. Since there's only one possible return type, we should make them return bool for convenience. Boolean conversion is also inexpensive on dart2wasm, so that shouldn't be an issue. Also adds helpers to operator_test to make sure any JS values are converted before they're compared, adding additional type checking through the conversion. CoreLibraryReviewExempt: Fixes type mismatch in backend-specific library. Change-Id: I7ff2e334e817e6e7d7d8d5091a4e5d570a496b03 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354702 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com> |
||
|---|---|---|
| .. | ||
| extension_type | ||
| import | ||
| isa | ||
| allowed_external_member_native_type_test.dart | ||
| allowed_external_member_type_test.dart | ||
| constants_test.dart | ||
| disallowed_generative_constructor_static_test.dart | ||
| disallowed_interop_libraries_test.dart | ||
| disallowed_tearoffs_static_test.dart | ||
| external_extension_members_test.dart | ||
| external_member_type_parameters_static_test.dart | ||
| external_static_member_lowerings_test.dart | ||
| external_static_member_lowerings_trusttypes_test.dart | ||
| external_static_member_lowerings_with_namespaces_test.dart | ||
| futurevaluetype_test.dart | ||
| generic_factory_test.dart | ||
| js_and_staticinterop_annotation_static_test.dart | ||
| js_array_impl_test.dart | ||
| js_array_proxy_or_ref_test.dart | ||
| js_array_test.dart | ||
| js_default_other_library.dart | ||
| js_default_test.dart | ||
| js_function_conversions_test.dart | ||
| js_string_test.dart | ||
| js_typed_array_test.dart | ||
| js_types_static_errors_test.dart | ||
| js_types_test.dart | ||
| jsobject_type_test.dart | ||
| member_test.dart | ||
| native_error_test.dart | ||
| number_test.dart | ||
| object_apis_static_interop_values_test.dart | ||
| operator_static_test.dart | ||
| operator_test.dart | ||
| regress_51307_test.dart | ||
| static_external_extension_members_static_test.dart | ||
| supertype_test.dart | ||
| supertype_transform_test.dart | ||
| top_level_member_annotation_static_test.dart | ||
| typed_data_test.dart | ||