mirror of
https://github.com/dart-lang/sdk
synced 2024-11-02 12:24:24 +00:00
73de586423
These tests had several issues. The fixes are aimed to reduce flakiness and remove invalid configurations where tests are not providing any value. Some of the issues include: * some tests interferered with each other causing a 18% flakiness rate in chrome: they used a common file system that ended up being shared in a single browser instance. This is why some tests failed when they find a file exists before it was created [1]. * some tests were not properly using async_helper/async_minitest, so they may complete before they finish executing * DDC no longer supports these APIs due to https://github.com/dart-lang/sdk/issues/53864. We don't intend to fix those issues, so there is no purpose in running these tests in DDC at this time. [1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766313714239949697/+/u/test_results/ignored_flaky_test_failure_logs Change-Id: I1dbb28eba2d962000a4d425563dbc1eb6b55dbed Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332266 Commit-Queue: Sigmund Cherem <sigmund@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com>
29 lines
959 B
Dart
29 lines
959 B
Dart
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:html';
|
|
|
|
import 'package:async_helper/async_minitest.dart';
|
|
|
|
main() {
|
|
if (!FileSystem.supported) return;
|
|
// Prepend this file name to prevent collisions among tests runnning on the
|
|
// same browser.
|
|
const prefix = 'fileapi_directory_';
|
|
|
|
test('directoryDoesntExist', () async {
|
|
final fs = await window.requestFileSystem(100);
|
|
try {
|
|
await fs.root!.getDirectory('${prefix}directory2');
|
|
} on DomException catch (error) {
|
|
expect(DomException.NOT_FOUND, error.name);
|
|
}
|
|
});
|
|
|
|
test('directoryCreate', () async {
|
|
final fs = await window.requestFileSystem(100);
|
|
var entry = await fs.root!.createDirectory('${prefix}directory3');
|
|
expect(entry.name, equals('${prefix}directory3'));
|
|
});
|
|
}
|