mirror of
https://github.com/dart-lang/sdk
synced 2024-11-02 09:43:08 +00:00
9db372e6f4
In https://dart-review.googlesource.com/c/sdk/+/191862 we added two new required fields to `Location`. Unfortunately this was a breaking change because plugins using an older version of the `analyzer_plugin` produce location objects without those fields, leading to deserialization failures. This CL makes those fields optional in order to fix the deserialization issue. Unfortunately, the `analyzer_plugin` package was published after the required fields were added. Making them optional is a breaking change because the constructor parameters go from being positional to being named parameters. We also neglected to update the version number of the protocol as part of the previous CL. Technically this is also a breaking change for clients of the analysis server, but given that they had no way to test to see whether these fields existed they would need to have been written as if the fields were optional in order to reference them at all, so I think that from a practical standpoint it isn't a breaking change. That does, however, raise the question of whether we should increment the version numbers as part of this CL. Change-Id: I35fc1f8e950669a3d8dd33cee6b81890261b5c47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206942 Reviewed-by: Danny Tuppeny <danny@tuppeny.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> |
||
|---|---|---|
| .. | ||
| analysis | ||
| channel | ||
| client | ||
| edit | ||
| integration | ||
| lsp | ||
| mock_packages | ||
| plugin | ||
| search | ||
| services | ||
| src | ||
| stress | ||
| timing | ||
| tool | ||
| utils | ||
| abstract_context.dart | ||
| abstract_single_unit.dart | ||
| analysis_abstract.dart | ||
| analysis_server_test.dart | ||
| benchmarks_test.dart | ||
| completion_test.dart | ||
| completion_test_support.dart | ||
| constants.dart | ||
| domain_analysis_test.dart | ||
| domain_completion_test.dart | ||
| domain_completion_util.dart | ||
| domain_diagnostic_test.dart | ||
| domain_execution_test.dart | ||
| domain_server_test.dart | ||
| mocks.dart | ||
| mocks_lsp.dart | ||
| protocol_server_test.dart | ||
| protocol_test.dart | ||
| socket_server_test.dart | ||
| test_all.dart | ||
| verify_no_solo_test.dart | ||
| verify_sorted_test.dart | ||
| verify_tests_test.dart | ||