9b294b846b
This enables the front end to skip the old-style (enum-based) exhaustiveness checking algorithm when pattern support is enabled, because with pattern support enabled, switches on enums are required to be exhaustive (this will be checked by the new exhaustiveness checking algorithm). That in turn means that in the future, when we remove support for language versions that lack patterns support, we will be able to remove the old-style exhaustiveness checking algorithm. This change has a small effect on code generated by the WASM back-end (the only back-end that uses `isExplicitlyExhaustive`): for a switch statement that is exhaustive *and* has an unreachable `default` clause, after testing all the cases, the WASM back-end will generate a branch to the `default` case. Previously it would instead generate an `unreachable` instruction. There should be no behavioural difference because the instruction in question is unreachable in both cases. Also, there should be negligible code size difference because the body of the `default` case is being emitted either way. Bug: https://github.com/dart-lang/sdk/issues/50419 Change-Id: Id6bd7d9a540cb1b4d9c3624db8ff494438276bea Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274924 Reviewed-by: Aske Simon Christensen <askesc@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> |
||
|---|---|---|
| .. | ||
| _fe_analyzer_shared | ||
| _js_interop_checks | ||
| analysis_server | ||
| analysis_server_client | ||
| analyzer | ||
| analyzer_cli | ||
| analyzer_plugin | ||
| analyzer_utilities | ||
| async_helper | ||
| build_integration | ||
| compiler | ||
| dart2js_info | ||
| dart2js_runtime_metrics | ||
| dart2js_tools | ||
| dart2native | ||
| dart2wasm | ||
| dart_internal | ||
| dartdev | ||
| dds | ||
| dds_service_extensions | ||
| dev_compiler | ||
| expect | ||
| front_end | ||
| frontend_server | ||
| js | ||
| js_ast | ||
| js_runtime | ||
| js_shared | ||
| kernel | ||
| language_versioning_2_7_test | ||
| meta | ||
| modular_test | ||
| native_stack_traces | ||
| nnbd_migration | ||
| scrape | ||
| smith | ||
| sourcemap_testing | ||
| status_file | ||
| telemetry | ||
| test_runner | ||
| testing | ||
| vm | ||
| vm_service | ||
| vm_snapshot_analysis | ||
| wasm_builder | ||
| .gitignore | ||
| BUILD.gn | ||
| OWNERS | ||
| pkg.status | ||
| README.md | ||
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency