9a83a75a10
Previously, the migration tool had a small amount of special case logic in `EdgeBuilder._dispatch` to ensure that if an `as` expression's type was annotated with `/*!*/`, that `/*!*/` wouldn't be misinterpreted as also applying to the `as` expression itself (causing a `!` operator to be inserted). This logic wasn't sufficiently general; it failed to handle `is` expressions (which can run into the same issue), and it failed to handle situations where the `is` or `as` expression was at the end of a larger expression (e.g. `y = x as T/*!*/;`). This change removes the special case logic and replaces it with a more general-purpose mechanism: when visiting any type name, if it ends in a `/*!*/`, the edge builder stores information about it in the `_nullCheckHints` field. This ensures that when visiting an expression ending in that type name, the `/*!*/` will be ignored (since `EdgeBuilder._handleNullCheckHint` skips any hints that are already stored in that field). This ensures that we properly handle both `is` and `as` expressions, as well as larger expressions that contain them. Change-Id: I2b902ef809b4cc5eb8b493fa4405c0f0c8c10a96 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202261 Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com> |
||
|---|---|---|
| .dart_tool | ||
| .github | ||
| benchmarks | ||
| build | ||
| client | ||
| docs | ||
| pkg | ||
| runtime | ||
| samples | ||
| samples-dev/swarm | ||
| samples_2 | ||
| sdk | ||
| tests | ||
| third_party | ||
| tools | ||
| utils | ||
| .clang-format | ||
| .gitattributes | ||
| .gitconfig | ||
| .gitignore | ||
| .gn | ||
| .mailmap | ||
| .packages | ||
| .style.yapf | ||
| .vpython | ||
| AUTHORS | ||
| BUILD.gn | ||
| CHANGELOG.md | ||
| codereview.settings | ||
| CONTRIBUTING.md | ||
| DEPS | ||
| LICENSE | ||
| PATENT_GRANT | ||
| PRESUBMIT.py | ||
| README.dart-sdk | ||
| README.md | ||
| sdk_args.gni | ||
| WATCHLISTS | ||
Dart
A client-optimized language for fast apps on any platform
Dart is:
-
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
-
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
-
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
-
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
-
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
License & patents
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Using Dart
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
Building Dart
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
Contributing to Dart
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.