dart-sdk/pkg
Konstantin Shcheglov 965af148f3 Issue 46758. LATE_FINAL_FIELD_WITH_CONST_CONSTRUCTOR.
Does not pass https://dart-review.googlesource.com/c/sdk/+/211140
yet, because requires one more fix, not reporting
CONST_CONSTRUCTOR_WITH_NON_FINAL_FIELD for const redirect constructors.

Bug: https://github.com/dart-lang/sdk/issues/46985
Bug: https://github.com/dart-lang/sdk/issues/46758
Change-Id: If6289b595545216d2d4e247214c5176a6a9d4a31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-08-25 15:30:47 +00:00
..
_fe_analyzer_shared [parser] Add useImplicitCreationExpression 2021-08-25 11:44:53 +00:00
_js_interop_checks [package:js] Allow external extension members for Native classes 2021-07-30 18:43:47 +00:00
analysis_server Better message for CREATE_MISSING_OVERRIDES 2021-08-24 21:33:24 +00:00
analysis_server_client Make Location.endLine and Location.endColumn optional fields in the protocol 2021-07-15 17:35:55 +00:00
analyzer Issue 46758. LATE_FINAL_FIELD_WITH_CONST_CONSTRUCTOR. 2021-08-25 15:30:47 +00:00
analyzer_cli Issue 45556. Analyze a requested file, even if it is excluded. 2021-07-20 18:27:13 +00:00
analyzer_plugin Fix a bug in OpType that caused it to compute the wrong completion location 2021-08-25 00:45:35 +00:00
analyzer_utilities Rename AnalysisSession.getXyz2() into getXyz(). 2021-07-12 22:42:58 +00:00
async_helper
build_integration Migrate pkg/build_integration to null safety 2021-07-17 15:45:04 +00:00
compiler [cfe] Report all compile-time errors found during constant evaluation 2021-08-24 11:42:53 +00:00
dart2js_info [dart2js_info] Fix tests after migration. 2021-08-13 18:47:41 +00:00
dart2js_runtime_metrics [dart2js_runtime_metrics] Allow exporting internal library 2021-08-12 22:47:22 +00:00
dart2js_tools Revert "[dart2js] Migrate dart2js_tools to null safety" 2021-08-19 01:23:15 +00:00
dart2native Discontinue dart2native (use dart compile) 2021-08-23 20:53:09 +00:00
dart_internal Bump dart_internal to support Dart 2.15. 2021-08-12 21:21:01 +00:00
dartdev Deprecate top level pub. 2021-08-24 08:34:58 +00:00
dds [dds] Add support for vmServiceInfoFile to DAP attachRequest 2021-08-25 00:47:34 +00:00
dev_compiler [cfe] Add UnresolvedKind for fine grained unresolved reporting 2021-08-25 09:51:54 +00:00
diagnostic
expect
front_end [parser] Add useImplicitCreationExpression 2021-08-25 11:44:53 +00:00
frontend_server [flutter-frontend] Shard flutter-frontend bot 2021-06-15 08:11:19 +00:00
js
js_ast [js_ast] dart format --fix 2021-08-25 03:08:21 +00:00
js_runtime [dart2js] Add dart:_dart2js_runtime_metrics library and package 2021-08-03 18:25:00 +00:00
kernel [kernel] Add 'dill_forensic' tool 2021-08-25 11:37:42 +00:00
language_versioning_2.7_test
meta [dart2js] Implement package:meta/dart2js.dart in terms of @pragma 2021-08-16 18:02:39 +00:00
modular_test
native_stack_traces Discontinue dart2native (use dart compile) 2021-08-23 20:53:09 +00:00
nnbd_migration analyze pkg/nnbd_migration on the bots 2021-08-13 20:29:43 +00:00
scrape Add script to scrape metadata annotation arguments. 2021-07-12 23:41:32 +00:00
smith Migrate pkg/smith to null safety. 2021-08-12 22:50:50 +00:00
sourcemap_testing Updating pkg:sourcemap_testing function resolution for method definition syntax. 2021-07-08 22:59:17 +00:00
status_file Migrate pkg/status_file to null safety. 2021-08-12 20:33:30 +00:00
telemetry deprecated field pubspec diagnostic 2021-06-22 17:26:09 +00:00
test_runner [test_runner] Support multiple arguments in update_static_error_tests.dart 2021-08-24 08:02:38 +00:00
testing [testing] Migrate pkg/testing to null safety 2021-07-27 19:45:38 +00:00
vm [vm] Enable lowering of typedef constructor tear-offs 2021-08-09 18:06:39 +00:00
vm_service [ Service ] Disable CPU sample block streaming 2021-08-06 16:02:55 +00:00
vm_snapshot_analysis Fix windows extension 2021-08-24 18:01:23 +00:00
.gitignore
BUILD.gn
pkg.status [dart2js_info] Fix tests after migration. 2021-08-13 18:47:41 +00:00
README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency