dart-sdk/pkg
Kallen Tu 944a2f691e [analyzer] Make constant assertion errors more helpful and specific.
If a condition is valid, but fails in an assert, make sure we report
that and a pseudo trace with context messages for the user to link
back to the problem.

This CL also starts building the stack trace when we call a super constructor for more detailed errors.

Bug: https://github.com/dart-lang/sdk/issues/36526
Change-Id: Ib9bc9841256644d2380d3f806e3bc3c9d84b37cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316625
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
2023-08-04 17:33:58 +00:00
..
_fe_analyzer_shared [cfe] Check for non-covariant type parameters in representation type 2023-08-03 14:04:40 +00:00
_js_interop_checks [_js_interop] Use #type for interop message 2023-08-01 11:12:19 +00:00
analysis_server [analyzer] Make constant assertion errors more helpful and specific. 2023-08-04 17:33:58 +00:00
analysis_server_client Use utf8.encode() instead of longer const Utf8Encoder.convert() 2023-07-24 09:28:38 +00:00
analyzer [analyzer] Make constant assertion errors more helpful and specific. 2023-08-04 17:33:58 +00:00
analyzer_cli [analyzer_cli] [dartdev] Fix several tests on Windows 2023-06-04 19:26:11 +00:00
analyzer_plugin Prepare analyzer_plugin 0.11.3 2023-08-02 19:37:58 +00:00
analyzer_utilities [analysis_server] Fix generation tests on Windows 2023-06-04 19:18:51 +00:00
async_helper
bisect_dart [tool] Bisection tool 2023-07-13 13:22:26 +00:00
build_integration
compiler [dart2js] Add alias mapping for deferred import IDs. 2023-08-03 22:13:40 +00:00
dap [dap] Regenerate DAP classes based on latest published version of spec 2023-06-20 17:29:24 +00:00
dart2js_info
dart2js_runtime_metrics
dart2js_tools
dart2native [vm/ffi] dartdev CLI native-assets 2023-05-30 09:10:28 +00:00
dart2wasm [dart2wasm] Handle unchecked as expressions 2023-08-04 14:06:49 +00:00
dart_internal Increase maximum sdk version constraint on dart_internal to 3.3.0 2023-07-27 00:29:42 +00:00
dartdev [pkg][dartdev] Error on native assets but not enabled 2023-07-24 11:25:06 +00:00
dds [ DDS ] Prepare for 2.9.4 release 2023-08-01 22:59:17 +00:00
dds_service_extensions Revert "Revert "Send DAP events through DDS"" - only check for event handler when DDS URI is also set. 2023-06-22 21:43:22 +00:00
dev_compiler [ddc] Run tests on canary and stable bots with matching settings 2023-08-04 15:22:38 +00:00
expect [vm] Add @pragma('vm:keep-name') annotation 2023-06-16 10:22:23 +00:00
front_end [cfe] Avoid crash on pattern switch statement in constant evaluator 2023-08-04 13:09:37 +00:00
frontend_server [frontend_server] Add --canary flag 2023-06-27 22:21:04 +00:00
js [pkg:js] Update min sdk version to 3.1.0-66.0.dev 2023-05-04 15:56:41 +00:00
js_ast [dart2js] Better const Maps and Sets 2023-06-20 23:44:08 +00:00
js_runtime [dart2js] Improve deferred part file logging. 2023-06-09 17:05:11 +00:00
js_shared
kernel [cfe] Check and add non-extension types in implements clause 2023-08-03 13:16:48 +00:00
language_versioning_2_7_test
meta
mmap [pkg] Support mmap with all the Linux architectures. 2023-05-11 17:15:26 +00:00
modular_test [modular_test] second attempt to fix shards. 2023-07-27 22:29:07 +00:00
native_stack_traces [vm] Rework awaiter stack unwinding. 2023-06-30 14:03:03 +00:00
nnbd_migration Revert "Separate out UNUSED_ELEMENT_PARAMETER from UNUSED_ELEMENT" 2023-07-24 16:25:07 +00:00
scrape
smith [infra] Change default NNBD to strong. 2023-05-24 20:48:36 +00:00
sourcemap_testing
status_file [infra] Make the sanitizer a first-class status variable. 2023-07-10 17:46:31 +00:00
telemetry Implement broad-spectrum filtering for possible path and filenames in exception strings. 2023-05-16 15:25:37 +00:00
test_runner [ddc] Update ddc stable targets to use new targets 2023-07-31 16:06:07 +00:00
testing [cfe] Remove unnecessary_null_comparison code 2023-06-08 08:46:47 +00:00
vm [vm] Fix expression evaluation in context of closures 2023-08-04 11:07:46 +00:00
vm_service [dart:developer] Add static Service.getObjectId method 2023-08-04 14:18:38 +00:00
vm_service_protos [VM/Service] Create package:vm_service_protos for distributing code for working with Perfetto protos 2023-06-15 19:01:00 +00:00
vm_snapshot_analysis [pkg/vm_snapshot_analysis] Allow old 'patched_class_' field. 2023-07-07 11:36:59 +00:00
wasm_builder [dart2wasm] Use new br_on_cast[_fail] encoding with input type 2023-08-03 16:56:15 +00:00
.gitignore
analysis_options.yaml
BUILD.gn
OWNERS
pkg.dart
pkg.status [deps/ffi] Unbundle package:native_assets_builder 2023-06-28 09:09:09 +00:00
README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency