languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-03 02:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/runtime
History
Zach Anderson 939ae55c00 Revert "[gn] Deprecate copy_trees()" 
This reverts commit f60d32167f.

Reason for revert: build failures in post submit

Original change's description:
> [gn] Deprecate copy_trees()
>
> Part of https://github.com/flutter/flutter/issues/144430
>
> Previously, this code did backflips to accomplish two goals
> 1. Collect the paths of all files that would be copied from one place to another after applying regex filters so that they could be listed as the "inputs" to a GN action.
> 2. Arrange so that the python script doing the above would only be invoked once during GN to reduce the cost of calling out to python.
>
> However, this is exactly the use-case for the "depfile" parameter to a GN action. Instead of running the script during GN to populate the "inputs" list, when we run the copy_tree.py script, we can instead ask it to generate a depfile to collect all the input files that were actually copied after applying the regex filter. Using that, we don't have to run the python script at all during GN.
>
> TEST=it builds
>
> Change-Id: I41a251ce4659119cdc3997bb2d6fc7ee0831bb6d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356481
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Zach Anderson <zra@google.com>
> Reviewed-by: Alexander Aprelev <aam@google.com>

Change-Id: Ie4409ed93a3c990fbce375dba1f2d9a3c735ea3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356308
Auto-Submit: Zach Anderson <zra@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Zach Anderson <zra@google.com>
2024-03-08 20:59:53 +00:00
..
bin Revert "[Fuchsia] Remove the legacy gn build rules for fuchsia" 2024-03-08 20:50:31 +00:00
docs [vm] Introduce pragma vm:deeply-immutable 2024-03-07 18:33:58 +00:00
include [vm] Remove dart:cli waitFor 2024-02-29 11:18:51 +00:00
lib [vm] Remove dead copy_parent_code flag. 2024-02-15 23:02:45 +00:00
observatory Revert "[gn] Deprecate copy_trees()" 2024-03-08 20:59:53 +00:00
platform Revert "[Fuchsia] Remove the legacy gn build rules for fuchsia" 2024-03-08 20:50:31 +00:00
tests [vm/compiler] Correct representation of shift rhs and speculative mode of BinaryUint32OpInstr 2024-03-08 15:35:20 +00:00
tools [vm] Remove core-jit snapshots 2024-02-14 00:08:30 +00:00
vm Revert "[Fuchsia] Remove the legacy gn build rules for fuchsia" 2024-03-08 20:50:31 +00:00
.clang-tidy
.gitignore
BUILD.gn Revert "[Fuchsia] Remove the legacy gn build rules for fuchsia" 2024-03-08 20:50:31 +00:00
codereview.settings
configs.gni [Runtime] Add extra_product_deps and extra_nonproduct_deps params to "library_for_all_configs_with_compiler" template 2023-04-14 19:51:40 +00:00
CPPLINT.cfg
OWNERS
PRESUBMIT.py Reland "Reland "[VM] Begin supporting Perfetto file recorder"" 2023-04-18 19:39:05 +00:00
runtime_args.gni Revert "[Fuchsia] Remove the legacy gn build rules for fuchsia" 2024-03-08 20:50:31 +00:00
vm-jit.shard.cml [test] Cleanup building Fuchsia packages/components. 2023-10-31 17:11:51 +00:00
vm.shard.cml [inspect] Update Inspect library usage 2024-02-12 18:18:01 +00:00