languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-24 20:05:13 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
dart-sdk/pkg
History
Ilya Yanok 936cdeeb2f Revert "Reland "Add more interface and final modifiers to dart:core."" 
This reverts commit e293eb809d.

Reason for revert: Breaks G3.

Original change's description:
> Reland "Add more `interface` and `final` modifiers to `dart:core`."
>
> This is a reland of commit 4f8333e80e
>
> Blocked on Flutter patch: https://github.com/flutter/engine/pull/40175
>
> Original change's description:
> > Add more `interface` and `final` modifiers to `dart:core`.
> >
> > Make intent explicit for classes which are intended as interfaces,
> > or which are not intended to be subclassed.
> >
> > Mainly classes which are pure interfaces are marked as such,
> > and platform-specific classes not intended for subclassing
> > are made `final`.
> >
> > The `final` classes includes `BigInt`, which is written to assume
> > that arguments inherit its private members
> > (it runs `_ensureSystemBigInt` on arguments).
> >
> > It also includes the `Expando`, `WeakReference` and `Finalizer` classes,
> > which are just intended as stand-alone implementation classes for accessing
> > platform-specific functionality.
> >
> > Change-Id: Ib770c265edff127a289a67fe72d15b9ff0499407
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287180
> > Reviewed-by: Stephen Adams <sra@google.com>
> > Commit-Queue: Lasse Nielsen <lrn@google.com>
> > Reviewed-by: Aske Simon Christensen <askesc@google.com>
> > Reviewed-by: Nate Bosch <nbosch@google.com>
> > Reviewed-by: Martin Kustermann <kustermann@google.com>
>
> CoreLibraryReviewExempt: Accepted in original CL.
> Change-Id: Id713edede4228801bb097a64734be4f2187f51a9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288206
> Reviewed-by: Aske Simon Christensen <askesc@google.com>
> Commit-Queue: Lasse Nielsen <lrn@google.com>
> Reviewed-by: Nate Bosch <nbosch@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

Change-Id: I05ff2fe44e5a13f20725eb122963d20243062c7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288503
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
2023-03-13 16:08:31 +00:00
..
_fe_analyzer_shared Revert "Reland "Add more interface and final modifiers to dart:core."" 2023-03-13 16:08:31 +00:00
_js_interop_checks [kernel] Move Pattern nodes to package:kernel 2023-03-13 08:43:07 +00:00
analysis_server [flip-patterns] Enable "records" and "patterns" experiment flags. 2023-03-10 20:02:23 +00:00
analysis_server_client Update SDK constraints for SDK packages. 2023-03-09 19:52:47 +00:00
analyzer [cfe] Change MapPattern.key to Expression 2023-03-13 10:05:16 +00:00
analyzer_cli Add boolean parse 2023-03-09 15:14:32 +00:00
analyzer_plugin [flip-patterns] Enable "records" and "patterns" experiment flags. 2023-03-10 20:02:23 +00:00
analyzer_utilities [analyzer] Separate the HTML parser utility from the DOM 2023-03-08 03:06:19 +00:00
async_helper [pkg/async_helper] use package:lints/recommended.yaml 2023-02-15 02:45:33 +00:00
build_integration
compiler Revert "Reland "Add more interface and final modifiers to dart:core."" 2023-03-13 16:08:31 +00:00
dart2js_info [dart2js_info] Update tests to allow using dart test command 2023-02-03 00:29:38 +00:00
dart2js_runtime_metrics [pkg/async_helper] use package:lints/recommended.yaml 2023-02-15 02:45:33 +00:00
dart2js_tools [deps] rev package:source_maps to the latest 2023-02-13 21:18:37 +00:00
dart2native [pkg/vm] Initial work on constant operating system fields and getters. 2023-02-10 16:29:50 +00:00
dart2wasm [dart2wasm] Support constants and comparison for Wasm numeric types 2023-03-13 14:16:08 +00:00
dart_internal
dartdev Remove support for dart __deprecated_pub 2023-03-13 12:06:08 +00:00
dds Add 'cache-control: no-store' header to DevTools server 2023-03-01 01:13:40 +00:00
dds_service_extensions Update SDK constraints for SDK packages. 2023-03-09 19:52:47 +00:00
dev_compiler [kernel] Move Pattern nodes to package:kernel 2023-03-13 08:43:07 +00:00
expect [test_runner] Cleanup unused compiler names 2023-03-07 02:09:16 +00:00
front_end Revert "Reland "Add more interface and final modifiers to dart:core."" 2023-03-13 16:08:31 +00:00
frontend_server Update SDK constraints for SDK packages. 2023-03-09 19:52:47 +00:00
js [js] Bump dependency after removing dependency on package:js. 2023-02-22 02:49:37 +00:00
js_ast [dart2js] Implement @pragma('dart2js:resource-identifier') 2023-02-28 03:00:18 +00:00
js_runtime [dart2js] Implement is-tests on records. 2023-01-27 20:24:20 +00:00
js_shared Update SDK constraints for SDK packages. 2023-03-09 19:52:47 +00:00
kernel [cfe] Change MapPattern.key to Expression 2023-03-13 10:05:16 +00:00
language_versioning_2_7_test Spelling 2023-01-30 18:29:59 +00:00
meta update @reopendocs 2023-03-07 21:21:01 +00:00
mmap [pkg] use package:lints/recommended.yaml as the default analysis config 2023-02-08 16:56:05 +00:00
modular_test [pkg/modular_test] use package:lints/recommended.yaml 2023-02-10 23:50:31 +00:00
native_stack_traces Spelling 2023-01-30 18:29:59 +00:00
nnbd_migration Add a few @Since annotations for mock SDK. 2023-03-07 21:44:57 +00:00
scrape Couple of tweaks to the scrape package. 2023-02-01 22:40:38 +00:00
smith [test_runner] Cleanup unused compiler names 2023-03-07 02:09:16 +00:00
sourcemap_testing [deps] rev package:source_maps to the latest 2023-02-13 21:18:37 +00:00
status_file [gardening] Fix vm/cc/IsolateReload_{TypedefToNotTypeDef,NotTypedefToTypeDef} tests 2023-02-20 13:54:29 +00:00
telemetry
test_runner [test_runner] Cleanup unused compiler names 2023-03-07 02:09:16 +00:00
testing [pkg/testing] use package:lints/recommended.yaml 2023-02-17 01:34:34 +00:00
vm [vm/tests] Update expectations for pkg/vm/test/transformations/type_flow/summary_collector_test 2023-03-12 09:35:39 +00:00
vm_service Update SDK constraints for SDK packages. 2023-03-09 19:52:47 +00:00
vm_snapshot_analysis Update SDK constraints for SDK packages. 2023-03-09 19:52:47 +00:00
wasm_builder [pkg/wasm_builder] use package:lints/recommended.yaml 2023-02-13 17:57:24 +00:00
.gitignore
analysis_options.yaml [pkg] use package:lints/recommended.yaml as the default analysis config 2023-02-08 16:56:05 +00:00
BUILD.gn
OWNERS
pkg.dart [pkg/async_helper] use package:lints/recommended.yaml 2023-02-15 02:45:33 +00:00
pkg.status [dartdev] Fix webdev integration test 2023-02-04 01:05:45 +00:00
README.md

README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency