mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 01:21:07 +00:00
8f4d4391e1
This test has non-deterministic failures (rate 30% on mac, 10% on linux and windows) caused likely by a data-race ([example log][1]). The test has a write to set the contents of a file, and a corresponding read. The error makes it appear as if the read occurred before the write completed. This API is part of the [createWriter][2] proposal, which was abandoned early on (almost a decade ago) and documented as deprecated. As a result I believe this test is providing coverage for obsolete functionality. In fact, the API for the `write` returns void and appears synchronous, but my guess is that it is not. There is no API to ensure the write completes as far as I know. An alternative here would be to use timers to add a significant delay between the operations. It is also worth noting that the [requestFileSystem][3] API to access the FileSystem (used here and in the fileapi tests) is also deprecated and not supported in firefox or safari. Given the flakiness issue and the fact that this API is already deprecated, I'm not really seeing the value in keeping the test. [1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767600632278735009/+/u/test_results/ignored_flaky_test_failure_logs [2]: https://developer.mozilla.org/en-US/docs/Web/API/FileSystemFileEntry/createWriter [3]: https://developer.mozilla.org/en-US/docs/Web/API/Window/requestFileSystem Change-Id: I92ad6399218c6a17cfa029a99b99afcfadde0035 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332282 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> |
||
|---|---|---|
| .. | ||
| analyzer | ||
| async | ||
| collection | ||
| convert | ||
| developer | ||
| fix_data_tests | ||
| html | ||
| isolate | ||
| js | ||
| js_interop_unsafe | ||
| math | ||
| mirrors | ||
| typed_data | ||
| web | ||
| lib.status | ||
| lib_analyzer.status | ||
| lib_app_jit.status | ||
| lib_dart2js.status | ||
| lib_dartdevc.status | ||
| lib_kernel.status | ||
| lib_precompiled.status | ||
| lib_vm.status | ||