dart-sdk/benchmarks
Alexander Markov 8ef90b8641 [benchmarks] Remove expensive Iterable.cast from NNBD version of ListCopy benchmark
Dart 2 version of this benchmark doesn't have this call.
Dart 3 (NNBD) is more strict and allows implicit casts only if casting
from dynamic, so it highlights places where types are incompatible.

However, Iterable.cast<int>() has a high overhead and it doesn't look
like a right way to suppress static type check in this case, as it
creates a new Iterable which would additionally cast each element.
Simple 'input as dynamic' cast is enough in this case and reflects
what was happening in Dart 2 case when types are incompatible.

Fixes https://github.com/dart-lang/sdk/issues/42506

Change-Id: I8d83796a53b53e6f567f533f3d5369cd29f6ad97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152700
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2020-06-26 22:51:08 +00:00
..
BigIntParsePrint [benchmark] BigIntParsePrint: Hoist value in all loops 2020-06-20 06:01:39 +00:00
Calls [benchmarks] Migrate Calls benchmark to NNBD 2020-06-23 05:41:57 +00:00
Example [benchmark] Migrate Example benchmark to be null safe. 2020-06-23 08:41:19 +00:00
FfiBoringssl [benchmark] Fork benchmarks for null safety and pin internal ones. 2020-06-02 12:53:24 +00:00
FfiCall [benchmarks/ffi] Add FfiCall benchmark with Handles 2020-06-15 13:27:16 +00:00
FfiMemory [benchmark] Fork benchmarks for null safety and pin internal ones. 2020-06-02 12:53:24 +00:00
FfiStruct [benchmark] Fork benchmarks for null safety and pin internal ones. 2020-06-02 12:53:24 +00:00
Isolate Migrate Isolate benchmarks to null safety 2020-06-22 23:45:55 +00:00
IsolateJson Migrate Isolate benchmarks to null safety 2020-06-22 23:45:55 +00:00
IsolateSpawn Migrate Isolate benchmarks to null safety 2020-06-22 23:45:55 +00:00
IsolateSpawnMemory Migrate Isolate benchmarks to null safety 2020-06-22 23:45:55 +00:00
ListCopy [benchmarks] Remove expensive Iterable.cast from NNBD version of ListCopy benchmark 2020-06-26 22:51:08 +00:00
RuntimeType [benchmark] Fork benchmarks for null safety and pin internal ones. 2020-06-02 12:53:24 +00:00
SoundSplayTreeSieve [benchmark] Fork benchmarks for null safety and pin internal ones. 2020-06-02 12:53:24 +00:00
TypedDataDuplicate [benchmarks/nnbd] Migrate TypedDataDuplicate benchmark to NNBD 2020-06-05 22:22:40 +00:00
Utf8Decode [benchmark] Fork benchmarks for null safety and pin internal ones. 2020-06-02 12:53:24 +00:00
analysis_options.yaml Roll benchmarks-internal to 02695da98bcf006b95630d3c386f4169d7ec4ecf 2020-06-26 01:56:03 +00:00