mirror of
https://github.com/dart-lang/sdk
synced 2024-10-05 17:35:02 +00:00
8d38a58c18
This allows to make the last explicitly named stubs shared between isolates. When sharing code stubs, we can't do patching at their entry anymore. Therefore, I had to remove patching support of the array allocation stub. Is this a functionality we want to keep? The change is mostly performance-neutral because optimized code has an inlined fast path for array allocation and only uses the stub for the slow-case. The only isolate-specific stubs left are object allocation stubs which are associated with their Class are per-isolate. Since this CL removes any isolate-specific stubs from StubCode, it becomes AllStatic. BUG= R=koda@google.com Review URL: https://codereview.chromium.org//1247783002 .
64 lines
1.6 KiB
C++
64 lines
1.6 KiB
C++
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h"
|
|
#if defined(TARGET_ARCH_X64)
|
|
|
|
#include "vm/debugger.h"
|
|
|
|
#include "vm/assembler.h"
|
|
#include "vm/code_patcher.h"
|
|
#include "vm/cpu.h"
|
|
#include "vm/instructions.h"
|
|
#include "vm/stub_code.h"
|
|
|
|
namespace dart {
|
|
|
|
uword CodeBreakpoint::OrigStubAddress() const {
|
|
return saved_value_;
|
|
}
|
|
|
|
|
|
void CodeBreakpoint::PatchCode() {
|
|
ASSERT(!is_enabled_);
|
|
uword stub_target = 0;
|
|
switch (breakpoint_kind_) {
|
|
case RawPcDescriptors::kIcCall:
|
|
case RawPcDescriptors::kUnoptStaticCall:
|
|
stub_target = StubCode::ICCallBreakpointEntryPoint();
|
|
break;
|
|
case RawPcDescriptors::kRuntimeCall:
|
|
stub_target = StubCode::RuntimeCallBreakpointEntryPoint();
|
|
break;
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
const Code& code = Code::Handle(code_);
|
|
saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
|
|
CodePatcher::PatchPoolPointerCallAt(pc_, code, stub_target);
|
|
is_enabled_ = true;
|
|
}
|
|
|
|
|
|
void CodeBreakpoint::RestoreCode() {
|
|
ASSERT(is_enabled_);
|
|
const Code& code = Code::Handle(code_);
|
|
switch (breakpoint_kind_) {
|
|
case RawPcDescriptors::kIcCall:
|
|
case RawPcDescriptors::kUnoptStaticCall:
|
|
case RawPcDescriptors::kRuntimeCall: {
|
|
CodePatcher::PatchPoolPointerCallAt(pc_, code, saved_value_);
|
|
break;
|
|
}
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
is_enabled_ = false;
|
|
}
|
|
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_X64
|