mirror of
https://github.com/dart-lang/sdk
synced 2024-09-21 03:13:14 +00:00
d358abfd1f
Many tests under `pkg`, like `pkg/js_ast` and `pkg/analyzer_cli` are meant to run as unit tests in the Dart VM. These were also being run in dart2js and causing flakiness because they took a long time to build on our CQ. Locally some of these tests compile in under 5s, but we see the compile-time vary among the bots a lot. I've observed cases close to 30s and some that reach the 1-minute timeout cutoff. Flakiness data show that this is happening between 5-7% of the runs, especially on linux bots. This CL stops running these tests on the dart2js configuration by changing which subset of the `pkg` suite is provided to dart2js. It also adjusts the .status file to skip a few suites for convenience on local testing only. This allows developers locally to run `test.py -n... pkg` without worrying about filtering out skipped suites. Addendum: after discussions on the CL we decided not to cmpletely drop coverage of js_ast tests on JS to ensure it can be used in browser environments in the future. To support this we made made the tests cheaper by removing the dependency on package:test. They will now only be run in a single configuration, which is all we need for this purpose. We can reevaluate and remove this if we continue to see timeouts. Change-Id: Idf0dbdd37e412ef71ba117ec979cb1e52585c431 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330704 Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> |
||
|---|---|---|
| .. | ||
| lib | ||
| test | ||
| analysis_options.yaml | ||
| LICENSE | ||
| OWNERS | ||
| pubspec.yaml | ||
| README.md | ||
js_ast
A library for creating JavaScript ASTs from templates.